Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80367 - the new libmusepack 1.1 clashes w/ gst-plugins-musepack
Summary: the new libmusepack 1.1 clashes w/ gst-plugins-musepack
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
: 82602 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-02-01 11:46 UTC by noddy
Modified: 2005-02-20 10:15 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gst-plugins libmusepack 1.1 patch (gst-plugins-musepack-0.8.7-to-0.8.8.v2.patch,33.64 KB, patch)
2005-02-04 07:11 UTC, Giacomo Perale
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noddy 2005-02-01 11:46:47 UTC
The new all-c libmusepack 1.1, although slotted, overwrites some of the older includes. Which is fine for the new xmms and bmp plugins, but kills gst-plugins-musepack-0.8.7 which is still not updated. I guess gst devel team might switch soon, but until then libmusepack-1.1 should at least block the gst plugin.

Reproducible: Always
Steps to Reproduce:
1. emerge =libmusepack-1.1
2. emerge gst-plugins-musepack

Actual Results:  
 i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I../../gst-libs 
-I../../gst-libs -D_LARGEFILE_SOURCE -D_FILE_OFFS 
ET_BITS=64 -pthread -I/usr/include/gstreamer-0.8 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/libxm 
l2 -DGST_DISABLE_DEPRECATED -Wall -O2 -march=athlon-xp -fomit-frame-pointer 
-pipe -MT libgstmusepack_la-gstmusepackdec.lo 
 -MD -MP -MF .deps/libgstmusepack_la-gstmusepackdec.Tpo -c gstmusepackdec.cpp  
-fPIC -DPIC -o .libs/libgstmusepack_la-gst 
musepackdec.o 
gstmusepackdec.cpp: In function `gboolean 
gst_musepack_stream_init(GstMusepackDec*)': 
gstmusepackdec.cpp:364: error: variable `StreamInfo si' has initializer but 
incomplete type 
gstmusepackdec.cpp:364: error: invalid use of undefined type `struct 
StreamInfo' 
/usr/include/musepack/mpc_dec.h:26: error: forward declaration of `struct 
StreamInfo' 
gstmusepackdec.cpp:371: error: `ERROR_CODE_OK' undeclared (first use this 
function) 
gstmusepackdec.cpp:371: error: (Each undeclared identifier is reported only 
once for each function it appears in.)
Comment 1 Carsten Lohrke (RETIRED) gentoo-dev 2005-02-01 12:30:15 UTC
noddy: No need to block anything. The dependency needs to be changed.
Comment 2 foser (RETIRED) gentoo-dev 2005-02-02 00:11:44 UTC
if it's abi incompatible (which is likely), then it is a reasonable step to block everything that uses it (i bet other libmpc based plugins will exhibit the same problems).

If libmusepack is slotted & overwrites its own includes (of the earlier 1.0 slot), then that is a bug & should be fixed asap.
Comment 3 Giacomo Perale 2005-02-04 07:11:58 UTC
Created attachment 50336 [details, diff]
gst-plugins libmusepack 1.1 patch

this has been fixed in gst-plugins CVS a few days ago:
http://bugzilla.gnome.org/show_bug.cgi?id=165446

I've got a modified ebuild who applies the patches, but it's ugly, because some
files must be renamed too (ext/musepack/*cpp --> .c) and I'm not so good with
patch and sed... but now everything works.
Comment 4 Carsten Lohrke (RETIRED) gentoo-dev 2005-02-04 07:37:42 UTC
>if it's abi incompatible (which is likely), then it is a reasonable step to block everything that uses it

Why? It just shouldn't go stable as long as depending stuff breaks and can't be marked stable as well. Who runs ~arch deserves what he get and can it mask locally, imho. :)

Comment 5 noddy 2005-02-04 11:31:13 UTC
Nononono, that's "masked". "Known-broken" is somehow canonically related to "masked". "Known-broken" simply... err, _transcends_ the notion of "unstable" ;)

I think it should be blocked instead of doing an ugly solution -- and even instead of fixing libmusepack slotting -- simply because it's a transient problem, to be gone in the next release of gst-plugins. Since AFAIK the gst plugin is the last package in portage dependant on the old library, that's actually the elegant solution ATM.
Comment 6 foser (RETIRED) gentoo-dev 2005-02-05 04:53:55 UTC
~arch is not meant to be broken lightly. Yes it is testing, but not for 'known broken' stuff. Anyway, people don't run straight ~arch or non-~arch systems and do whatever you can imagine to their sys, adding a couple of safeguards if possible is not a bad idea.

Anyway, I'm more concerned about the slotting, if what is said is true (both slots occupying the same space), this should be fixed NOW, not later.
Comment 7 Matthieu Le Jeune 2005-02-19 11:35:43 UTC
*** Bug 82602 has been marked as a duplicate of this bug. ***
Comment 8 foser (RETIRED) gentoo-dev 2005-02-20 10:15:45 UTC
all of these issues have been taken care of.