don't want unnecessary packages instaleld and i suppose much users have alsa-utils installed... will attach ebuild for 0.3.6 edited by me (it works but i haven't any experience in making ebuilds earlier...) Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 49847 [details] proposed ebuild (needs some edit)
What exactly is pmidi? If someone had alsa in the USE flags, wouldn't they have alsa-utils anyway? I'm not sure I see the point in an alsa-utils USE flag.
well... have you seen ebuild in portage? that ebuild only has option for using pmidi or timidity for playing midi.... as i wanted to play midis using aplaymidi (because didn't wanted to install pmidi as i had alsa-utils already and didn't see any advantages of pmidi over aplaymidi (and didn't wanted to install unnecessary for me package) and my Cel300 is to slow for timidity)) and second - i didn't wanted to make too much changes to ebuild (the original used pmidi with alsa flag) well, i hope you see the point :) ps: sorry for my english (i know - its far from good :( ) almost forgot - pmidi is midi player capable of using alsa ... i suppose ( but haven't seen it by myself though)
and i suppose most people using alsa have alsa-utils .... so why there is no option for using aplaymidi ?
as for "alsa-utils" flag .... maybe it would be better to have "pmidi" flag for pmidi and use aplaymidi as default for "alsa" flag?
Created attachment 53412 [details] openttd-0.3.6-r1.ebuild i've polished ebuild .... now it has "pmidi" flag for using pmidi and "alsa" flag now sets aplaymidi also polished postinstall info ...
That looks a lot better and I like the idea of using the pmidi USE flag more than alsa-utils. You did miss one check in src_compile for the alsa-utils USE flag.
Created attachment 53422 [details] openttd-0.3.6-r1.ebuild fixed missed use of "alsa-utils" flag
Created attachment 53425 [details] openttd-0.3.6-r1.ebuild
well i'm not sure how can i make desktop entry to run /usr/games/bin/openttd -m extmidi instead of /usr/games/bin/openttd
1. Change "inherit games" to "inherit eutils games" 2. Use doicon/newicon for copying the icon to /usr/share/pixmaps 3. I would recommend naming the icon to be the same as the package, so opentdd.png 4. make_desktop_entry "openttd -m extmidi" "OpenTTD" openttd.png If you have any other questions, feel free to ask them.
1.you see - icons which package provides are varying in size from 16x16 to 128x128 and i simply not sure which to use for desktop entry .... maybe the biggest? 2.only now noticed that ebuild is not installing provided with package scenarios and scripts examples. will include this in ebuild....
Created attachment 53502 [details] openttd-0.3.6-r1.ebuild i hope this is the last version .... as i tested it yesterday with various flags on my home pc ... changes from the original euild: 1. inherits eutils (for using doicon, i suppose) 2. uses doicon for icons (instead of insinto+newins) 3. has option for playing midi with aplaymidi with "alsa" flag and "pmidi" flag for pmidi 4. installs scenarios and sample scripts 5. more postinstall info
Created attachment 53503 [details] openttd-0.3.6-r1.ebuild ooops
Created attachment 53504 [details] openttd-0.3.6-r1.ebuild now installs ALL of the provided icons
almost forgot to mention another change from original ebuild it creates desktop entry for openttd -m extmidi with alsa,timidity or pmidi flag . thus enabling midi playback by default
Are there any advantages of using pmidi over aplaymidi? If not maybe we should drop pmidi support, otherwise we will have to add use-flags for <insert every midi playing app here>.
as i've read on pmidi homepage it is COMPLETELY IDENTICAL to aplaymidi :) so, i suppose it is right to drop pmidi support .... (the latest pmidi version is 20 dec 2003 ...) and i can't see any reason why it is in the ebuild which is in portage and, yeah, this bug was not to include some more midi software (pmidi was in the original ebuild) but to include support for standard midi player which comes with sound drivers (well...almost (as alsa-utils is a separate package))
Created attachment 53688 [details] openttd-0.3.6-r1.ebuild dropped pmidi
Thanks for the ebuild Anton. I have added it to portage but with some modifications. Please test it and let me know if there are any problems.
There are problems :) (i suppose that this is mistype (or whatever this would be in english)) here: use alsa && myopts="${myopts} MIDI=/usr/bin/pmidi" PMIDI! pmidi has been dropped from dependancies (in favour for alsa-utils) !timidity? ( alsa? ( media-sound/alsa-utils ) ) string above should be use alsa && myopts="${myopts} MIDI=/usr/bin/aplaymidi"
Weird, I'm sure I changed that line. I must've hit undo by mistake or something. Anyway, it is corrected in CVS.
ok :)
