Created attachment 719247 [details, diff] hpaio net discovering According to https://forums.gentoo.org/viewtopic-p-8627655.html it could be very interesting to add a patch and a USE flag to apply it for hpaio net discovering.
No comment one year later ?
I would say /etc/portage/pactches is the place where this should go. If you really want this configurable please brimg this issue upstrem.
(In reply to Daniel Pielmeier from comment #2) > I would say /etc/portage/pactches is the place where this should go. That's already the case : # cat /etc/portage/patches/net-print/hplip/hpaio_net_discorery.patch diff -ur hplip-3.20.11.orig/scan/sane/hpaio.c hplip-3.20.11/scan/sane/hpaio.c --- hplip-3.20.11.orig/scan/sane/hpaio.c 2020-11-29 20:03:52.000000000 -0400 +++ hplip-3.20.11/scan/sane/hpaio.c 2021-06-25 09:26:11.786204535 -0400 @@ -376,7 +376,7 @@ { DBG(8, "sane_hpaio_get_devices(local=%d): %s %d\n", localOnly, __FILE__, __LINE__); ResetDeviceList(&DeviceList); - DevDiscovery(localOnly); + DevDiscovery(0); *deviceList = (const SANE_Device **)DeviceList; SANE_Device*** devList; orblite_get_devices(devList, localOnly); > If you really want this configurable please brimg this issue upstrem. But I just thought it might be useful to others besides me. It seemed to me that it was the role of the packager to improve the usability of the packaged software without sending the users back to the developer, as far as it is within his reach.
The bug is here for everyone to find and it is not a big deal to apply. I have also not experienced an uproar because it is not there. I don't think it is my task to add every single line patch with a use flag. I think it does not make sense here. Maybe you recognised the number of patches already applied to hplip. I have to test and adapt them if necessary with every new version i bump. So I try to keep this number low because most of them will never be included although there is an upstream bug already (most of them reported by me). Even my time is limited and I try to use it well. Not only for things Gentoo. And yes maybe it is my task to report this things upstream, but now you recognised that reality is different. If you want to help and waste a little time feel free to do so. Why? Because with the years I am maintaining hplip I found HP does not care a lot about it and does not seem to put a lot of ressources into it. They add support for new models but overall the code mainaineance is bad. So if it is not absolutely necessary I don't bother with bringing it upstream.
useless
(In reply to Christophe PEREZ from comment #5) > useless That's extremely impolite. Have you reoprted it upstream?
(In reply to Christophe PEREZ from comment #5) > useless Your comment is totally unacceptable and offensive. If you are interested on fix that thing it's up to you to report upstream the problem and ask to fix it rather than post a patch here and insult the maintainer because he asked to you the same thing I've said now. On top of that you are posting a patch here where no one outside gentoo could find it useful or find it at all. In the end please consider to be more condescending next time.
