Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 798408 - [GURU] Many packages added with either no maintainer or unconsenting @gentoo.org maintainer
Summary: [GURU] Many packages added with either no maintainer or unconsenting @gentoo....
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Contributor problems (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GURU project: Gentoo devs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-24 14:17 UTC by John Helmert III
Modified: 2021-06-25 16:55 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2021-06-24 14:17:46 UTC
Alessandro added dozens of packages removed from Gentoo in one commit and only haphazardly made them maintainer-needed in a later commit, with others being maintained by a variety of @gentoo.org maintainers (see below Repology links). I've no idea about the Git standards in GURU but this should have been done at a minimum with one commit per package while fixing maintainers in the same commit as adding the package.

https://repology.org/maintainer/prometheanfire%40gentoo.org
https://repology.org/maintainer/openstack%40gentoo.org
https://repology.org/maintainer/xen%40gentoo.org
https://repology.org/maintainer/python%40gentoo.org

It also seems unacceptable to add dozens of packages straight to maintainer-needed, that does nothing but increase workload on those involved with GURU.

app-protage/showbuild also has a non-GURU maintainer in metadata added by Alessandro. I would be unsurprised if there are others, but @gentoo.org addresses are easier to grep for.
Comment 1 Nowa Ammerlaan gentoo-dev 2021-06-24 15:08:00 UTC
@Alessandro, please either add yourself as the maintainer for these packages or drop to maintainer-needed asap. 

I admire your desire to save all these last-rited packages. However, please consider that sometimes there is a good reason a package is being removed, and please consider this reason before moving packages into ::guru. Also, remember that you are not alone. If you think a package should be saved but do not feel like adding yourself as the dedicated maintainer, it might be better to wait a bit. There might be someone else who also thinks the package should be saved and who does want to become the dedicated maintainer.

@guru-trusted, in the future please also check if the metadata file contains only the committer as the maintainer (and in particular that it does not contain any @gentoo.org addresses). It is very easy to forget to update the metadata file when moving packages from somewhere else, it happens rather often that there is a left over @gentoo.org address (especially proxy-maint@gentoo.org is very often added to ::guru by accident).
Comment 2 Alessandro Barbieri 2021-06-24 17:34:09 UTC
"app-protage/showbuild also has a non-GURU maintainer in metadata added by Alessandro. I would be unsurprised if there are others, but @gentoo.org addresses are easier to grep for."

Post back the output of these two commands:
equery m showbuild
pquery --repo guru --blame showbuild
Comment 3 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2021-06-24 20:05:27 UTC
(In reply to Alessandro Barbieri from comment #2)
> "app-protage/showbuild also has a non-GURU maintainer in metadata added by
> Alessandro. I would be unsurprised if there are others, but @gentoo.org
> addresses are easier to grep for."
> 
> Post back the output of these two commands:

Or I'll link to the source of the issue directly:

https://gitweb.gentoo.org/repo/proj/guru.git/tree/app-portage/showbuild/metadata.xml#n11

You need upstream's consent to list them in metadata in this way. Do you have it?
Comment 4 Alessandro Barbieri 2021-06-24 20:54:08 UTC
> You need upstream's consent to list them in metadata in this way.

There is no such a thing in the devmanual
Comment 5 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2021-06-24 21:59:30 UTC
Sorry, seems I'm wrong about that bit. In any case, please address what Andrew told you to address.