Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 79766 - dc-qt should have xine-lib as an optional dependency
Summary: dc-qt should have xine-lib as an optional dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-27 12:12 UTC by Petteri Räty (RETIRED)
Modified: 2005-07-13 11:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2005-01-27 12:12:15 UTC
From README:
Requirements:
Qt 3.2.x
Recent version of DCTC (http://ac2i.homelinux.com/dctc/).

from ./configure --help :

Optional Packages:
  --with-PACKAGE[=ARG]    use PACKAGE [ARG=yes]
  --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)
  --with-qt-dir=DIR            qt-dir in DIR
  --with-qt-moc=DIR            qt-moc in DIR
  --with-qt-includes=DIR       qt-includes in DIR
  --with-qt-libs=DIR           qt-libs in DIR
  --with-pthread-libs=DIR      bz2-pthread in DIR
  --with-xine-prefix=DIR       xine installed in DIR
  --with-xine-exec-prefix=DIR  exec prefix where xine is installed is DIR

So xine-lib should be under xine USE flag.

Reproducible: Always
Steps to Reproduce:
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2005-01-28 04:20:58 UTC
Simple adding xine?( ) around the dependency does the job for people who don't want xine.
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2005-01-28 14:06:27 UTC
if i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H  -I. -I. -I.. -DQT_THREAD_SUPPORT -I/usr/qt/3/include      -DDISABLE_PREVIEW -O2 -DPREFIX=/usr -MT preview_widget.o -MD -MP -MF ".deps/preview_widget.Tpo" \
  -c -o preview_widget.o `test -f 'preview_widget.cc' || echo './'`preview_widget.cc; \
then mv -f ".deps/preview_widget.Tpo" ".deps/preview_widget.Po"; \
else rm -f ".deps/preview_widget.Tpo"; exit 1; \
fi
player_xine.cc:1066: error: syntax error before `::' token
player_xine.cc:1071: error: ISO C++ forbids declaration of `resize' with no
   type
player_xine.cc:1071: error: initializer list being treated as compound
   expression
player_xine.cc:1072: error: ISO C++ forbids declaration of `setMinimumSize'
   with no type
player_xine.cc:1072: error: initializer list being treated as compound
   expression
player_xine.cc:1073: error: ISO C++ forbids declaration of `setSizePolicy' with
   no type
player_xine.cc:1073: error: initializer list being treated as compound
   expression
player_xine.cc:1074: error: syntax error before `if'
player_xine.cc:1075: error: syntax error before `->' token
player_xine.cc:1079: error: syntax error before `::' token
player_xine.cc:1082: error: prototype for `bool av_player_xine::play(QString&)'
   does not match any in class `av_player_xine'
player_xine.h:46: error: candidate is: virtual bool
   av_player_xine::play(QString&, QString&)
player_xine.cc:1093: error: syntax error before `::' token
make[3]: *** [player_xine.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/var/tmp/portage/dc-qt-0.1.1/work/dc-qt-0.1.1/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/dc-qt-0.1.1/work/dc-qt-0.1.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/dc-qt-0.1.1/work/dc-qt-0.1.1'
make: *** [all] Error 2

from http://dc-qt.sourceforge.net/  

xine note: if you don't have a global installation of xine on your system, dc-qt 0.1.1 will fail to compile. This has been corrected in the 0.1.2 version.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2005-01-28 14:16:36 UTC
0.1.2 compiles and starts without problems without xine installed. 
Here's diff I used:
5c5
< IUSE=""
---
> IUSE="xine"
17c17
<       >=media-libs/xine-lib-1_rc5 )"
---
>       xine? ( >=media-libs/xine-lib-1_rc5)"
Comment 4 Jon Hood (RETIRED) gentoo-dev 2005-01-29 11:39:40 UTC
Patteri, if you could make a diff that can cause dc-qt to compile with or without xine support, even if xine is installed, I would be glad to apply it. Some people may have xine installed but not want xine support in dc-qt. With your current diff, the user has no choice to enable or disable xine support if xine is installed.
Comment 5 Karol Wojtaszek (RETIRED) gentoo-dev 2005-07-13 11:05:18 UTC
Fixed in portage.