Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 79764 - New USER_ALLOWED_FLAGS variable
Summary: New USER_ALLOWED_FLAGS variable
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-27 12:10 UTC by Kaiting Chen
Modified: 2005-01-30 01:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kaiting Chen 2005-01-27 12:10:17 UTC
The flag-o-matic eclass, when using the function strip-flags, strips all flags that aren't in ALLOWED_FLAGS (and UNSTABLE_FLAGS if running a ~ARCH). Sometimes, though, a user will really want to use a flag that they know is stable for their system, or one that speeds up compilation but does not change actually code, or something else that they just want to use regardless. I think there should be a USER_ALLOWED_FLAGS variable that they could put in /etc/make.conf. Then, we could add the line somewhere in the strip-flags function:

ALLOWED_FLAGS="${USER_ALLOWED_FLAGS} ${ALLOWED_FLAGS}"

That way, if a user really wanted to use a flag, it would not be stripped.

Reproducible: Always
Steps to Reproduce:
Comment 1 SpanKY gentoo-dev 2005-01-28 05:08:48 UTC
strip-flags is to produce a sane system

if the user is allowed to control the idea of a 'sane system', bad things
can (and do) happen
Comment 2 Kaiting Chen 2005-01-28 16:10:34 UTC
Yeah, but that's the user's own fault. I mean, just because you implement this doesn't mean that everyone's going to use it. It's just annoying having to update the eclass every time I emerge --sync. If we could overlay eclasses, that would be great to. But as things stand, I don't think it would cause any problems for this to be implemented, and with a warning in /etc/make.conf.example such as: "This can and probably will break your system."
Comment 3 Kaiting Chen 2005-01-28 16:11:59 UTC
And another thing. Fomit-frame-pointer rarely causes problems. In fact, I have my entire system compiled with that flag, (except for glibc and the like, which explicitly filter it out). Lots of ebuilds just call strip-flags just for the heck of it, which unfortunately, filters out fomit-frame-pointer.
Comment 4 SpanKY gentoo-dev 2005-01-28 20:14:36 UTC
i dont care, it's not going to happen
Comment 5 SpanKY gentoo-dev 2005-01-30 01:37:36 UTC
hrm, neglected to close the bug last time
Comment 6 Nicholas Jones (RETIRED) gentoo-dev 2005-01-30 01:44:01 UTC
You can overlay eclasses, btw.