Bug 795141 – games-action/supertuxkart-1.2-r1: add USE 'client' to set `-DSERVER_ONLY`

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description Lars 2021-06-09 22:12:39 UTC]

Running supertuxkart as server on a headless system may cause trouble if it was build with `-DSERVER_ONLY=ON`. This ebuild adds the USE `client` which will build with `-DSERVER_ONLY=ON` if enabled (default), with `-DSERVER_ONLY=OFF` else.

Reproducible: Always

Steps to Reproduce:
1.emerge supertuxkart with `-DSERVER_ONLY=ON`
2.on a system without SDL start a STK sever: `supertuxkart --lan-server=test --network-console`
3.on the same system try to add AI carts: `supertuxkart --connect-now=127.0.0.1:2759 --network-ai=2`
Actual Results:  
Fails with 

Unable to initialize SDL!: No available video device

Expected Results:  
It should not fail.

Building supertuxkart with `-DSERVER_ONLY=OFF` fixes this.

[Comment 1 Lars 2021-06-09 22:14:06 UTC]

Created attachment 715011 [details]
ebuild with USE `client`

[Comment 2 Sam James 2021-06-10 00:05:04 UTC]

(Let's try unbundle libsquish while at it?)

[Comment 3 Lars 2021-06-10 05:16:48 UTC]

(In reply to Lars from comment #0)

> Building supertuxkart with `-DSERVER_ONLY=OFF` fixes this.

This should have read:

Building supertuxkart with `-DSERVER_ONLY=ON` fixes this.

[Comment 4 Lars 2021-06-10 07:05:22 UTC]

(In reply to Sam James from comment #2)
> (Let's try unbundle libsquish while at it?)

Citing from IRC #supertuxkart@libera

fgdb | [02:21:45] [FNode] <Weiss-Fder[m]> <FGD-Bridge "[Libera]:

> If you just look at the latest ebuild, you will see this is not difficult at all. Alas, there is no reason AFAIK for them to disable IPv6 support for STK like they are doing now.

I did not enable IPv6 support in my ebuild, because I do not know about the background. But maybe you do?

[Comment 5 Ionen Wolkens 2021-06-10 07:34:17 UTC]

(In reply to Lars from comment #4)
> I did not enable IPv6 support in my ebuild, because I do not know about the
> background. But maybe you do?
I didn't look in this package much yet but, comparing system enet and bundled enet, I certainly don't see any reference to ipv6 on the system 1.3.17 version if it matters.

[Comment 6 Ionen Wolkens 2021-06-10 07:48:55 UTC]

But considering that means losing features, maybe having a USE to (optionally) use bundled enet with ipv6 would make sense.

[Comment 7 Lars 2021-06-15 20:48:34 UTC]

Created attachment 716364 [details]
Fixing a segfault in headless STK LAN servers

[Comment 8 Lars 2021-06-15 20:49:19 UTC]

Created attachment 716367 [details, diff]
Patch fixing segfault on headless STK LAN servers