Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 79319 - media-video/mplayer-1.0_pre6 ebuild and "libdv" support
Summary: media-video/mplayer-1.0_pre6 ebuild and "libdv" support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-24 05:21 UTC by TGL
Modified: 2005-01-24 13:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-1.0_pre6--dv_use_flag.patch (mplayer-1.0_pre6--dv_use_flag.patch,1.37 KB, patch)
2005-01-24 05:23 UTC, TGL
Details | Diff
mplayer-1.0_pre6--dv_use_flag-bis.patch (mplayer-1.0_pre6--dv_use_flag-bis.patch,1.57 KB, patch)
2005-01-24 05:27 UTC, TGL
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2005-01-24 05:21:40 UTC
Some small issues with the mplayer-1.0_pre6 ebuild regarding libdv support:
 - the "dv" local USE flag that is used in RDEPEND doesn't have its use;local.desc entry (or should the flag become global since it's also used by media-libs/libquicktime, media-video/mjpegtools and media-video/transcode?)
 - it is not declared in IUSE.
 - the flag doesn't enforce the --{enable,disable}-libdv configure option, thus the lib is autodetect (seen it because my last "emerge depclean" removed libdv and thus broke mplayer dynamic linking).

I will attach a small patch for the 2 last issues. It assumes that libdv support is only required if USE=encode and should be disabled otherwise, with the same logic that is in RDEPEND. But looking at the "./configure --help", i see they speak of both encoding and decoding support for libdv, so maybe that should be changed and "dv" should not depend on "encode". I don't know for sure since i don't use it, i let you decide.
Comment 1 TGL 2005-01-24 05:23:05 UTC
Created attachment 49359 [details, diff]
mplayer-1.0_pre6--dv_use_flag.patch
Comment 2 TGL 2005-01-24 05:27:03 UTC
Created attachment 49361 [details, diff]
mplayer-1.0_pre6--dv_use_flag-bis.patch

This version is in case you decide to drop the dv->encode USE flag dependency.
Comment 3 Jan Brinkmann (RETIRED) gentoo-dev 2005-01-24 13:49:00 UTC
made the changes which your first patch suggested. thanks.