This is an ebuild for the Clearlooks engine at http://gnome-look.org/content/show.php?content=19527 Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 49358 [details] ebuild for Clearlooks 0.2.2
the ebuild seems to be mostly copied from an unrelated package. Read the ebuild guide don't inherit eclasses if you aren't using them don't use full tarball path in src_uri only keyword what archs you have tested on probably needs a pkgconfig dep you should look into the gtk-engines eclass
Created attachment 49592 [details] New Improved version of clearlooks ebuild! Thank you for the pointers, Joe. I hope this version is better :)
This worked pretty well for me. I just have a question: shouldn't it be named gtk-engines-clearlooks instead of clearlooks-engine, in the ebuild?
*** Bug 83231 has been marked as a duplicate of this bug. ***
Version 3 has been released but when emerging i get an acces violation. I would also suggest not to use gnomelook but the sourceforge download site. ************ ACCESS DENIED unlink: /usr/share/themes/Clearlooks/metacity-1/metacity-theme -1.xml /bin/install: cannot remove `/usr/share/themes/Clearlooks/metacity-1/metacity-th eme-1.xml': Permission denied make[4]: *** [install-themeDATA] Error 1 make[4]: Leaving directory `/var/tmp/portage/gtk-engines-clearlooks-0.3/work/gtk -engines-clearlooks-0.3/themes/Clearlooks/metacity-1' make[3]: *** [install-am] Error 2 make[3]: Leaving directory `/var/tmp/portage/gtk-engines-clearlooks-0.3/work/gtk -engines-clearlooks-0.3/themes/Clearlooks/metacity-1' make[2]: *** [install-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/gtk-engines-clearlooks-0.3/work/gtk -engines-clearlooks-0.3/themes/Clearlooks' make[1]: *** [install-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/gtk-engines-clearlooks-0.3/work/gtk -engines-clearlooks-0.3/themes' make: *** [install-recursive] Error 1 !!! ERROR: x11-themes/gtk-engines-clearlooks-0.3 failed. !!! Function einstall, Line 524, Exitcode 2 !!! einstall failed !!! If you need support, post the topmost build error, NOT this status message. --------------------------- ACCESS VIOLATION SUMMARY --------------------------- LOG FILE = "/tmp/sandbox-x11-themes_-_gtk-engines-clearlooks-0.3-15713.log" unlink: /usr/share/themes/Clearlooks/metacity-1/metacity-theme-1.xml --------------------------------------------------------------------------------
Created attachment 52384 [details, diff] sandbox patch This patch should fix the sandbox problem, need to run auto* stuff as well after applying it.
Created attachment 52395 [details] ebuild for gtk-engines-clearlooks-0.3 An ebuild for clearlooks 0.3 based on the one for 0.2.2 by Richard Stellingwerff, which utilizes the patch provided by foser.
New ebuild work fine and you can mark it ~amd64.
Change SRC_URI to: mirror://sourceforge/clealooks/${MY_PN}-${PV}.tar.bz2
Created attachment 52476 [details] updated ebuild for gtk-engines-clearlooks-0.3 Added ~amd64 as recommended by Sander Sweers. Updated SRC_URI as recommended by Yaron Tausky.
I have placed the gtk-engines-clearlooks-0.3 ebuild in my overlay and while digesting I got: QA Notice: has_version() in global scope: eclass gtk-engines2 QA Notice: has_version() in global scope: eclass gtk-engines2 QA Notice: has_version() in global scope: eclass gtk-engines2 Do not know if this is a problem of the ebuild or the eclass.
Ivan, I was getting this as well. I did a emerge sync, to see if there was an updated eclass, and apparently there was. Emerging the gtk-engines-clearlooks-0.3-r1 doesn't give that QA notice any longer, for me at least.
Looks like you are right, Josh. I just synced and re-digested and did not get any QA warnings.
clearlooks-0.4 is out, it works by renaming the ebuild from this bug...
Created attachment 52676 [details] gtk-engines-clearlooks-0.4.ebuild Updated ebuild for new version. The patch previously mentioned doesn't seem to be required anymore.
Created attachment 52703 [details] gtk-engines-clearlooks-0.4-r1.ebuild In this version there is an optional animated progressbar that can be enabled with "--enable-animation" configure flag. I added the USE "animation" to the ebuild to get this.
I don't think there should be USE=animation. Just enable it by default IMO, and that should be done by adding: econf --enable-animation under src_compile() I have yet to see it in performance though...
I don't think it should be mandatory -- it's purely a matter of taste (and I, for one, favour simplicity).
Created attachment 52736 [details] gtk-engines-clearlooks-0.4-r2.ebuild Uses a patch to address a bug mentioned in Clearlook's bugs, which refers to a gnome bug. http://sourceforge.net/tracker/index.php?func=detail&aid=1156793&group_id=129376&atid=714612 http://bugzilla.gnome.org/attachment.cgi?id=38111&action=view)
Created attachment 52738 [details, diff] fix for gnome bug 168897
There seems to be a problem with Clearlooks in Gaim -- when using the File Transfers window, transfer progress bars show up with glitches, and when transfer begins it uses the Industrial engine (my previous theme) progress bar instead of the Clearlooks one.
Created attachment 53828 [details] gtk-engines-clearlooks-0.4-r3.ebuild Slightly different ebuild for clearlooks (used gtk-engines-smooth as the base). Personally, I cannot tell if --enable-animation is doing anything. But it is getting passed to ./configure. And I don't get any problems with Gaim.
Nice work. =)
Created attachment 54026 [details] gtk-engines-clearlooks-0.5.ebuild Updated to version 0.5. There is no need to apply the patch for gnome bug 168897 as it was solved. I removed the USE animation because it doesn't work anymore. According to the changelog the metacity theme was removed, so it must be downloaded separately from http://www.gnome-look.org/content/show.php?content=21237.
This is not directly concerning the ebuild but, does anyone know what happened to Clearlooks Milk, that used to be within this package before?
The most recent release doesn't seem to work for me. When I switch to one of the Clearlooks theme, I get the following error: /usr/share/themes/Clearlooks/gtk-2.0/gtkrc:46: error: unexpected identifier `menuitemstyle', expected character `}' Aside from that, I don't think any of the functions, src_unpack, src_compile, and src_install, need to be overriden. Having them commented out seems to unpack/compile/install without problem.
Lame. I think we should install the metacity theme too.
Created attachment 54157 [details] gtk-engines-clearlooks-0.5.ebuild I modified the ebuild to install also the metacity theme, this required overriding src_install() but it works here...
Created attachment 54160 [details] gtk-engines-clearlooks/gtk-engines-clearlooks-0.5.ebuild ops, slight modification
Great - just remember to use tabs and not spaces in ebuilds Also, the ebuild can't download clearlooks-metacity, I had to manually get it from gnome-look and rename it.
you're right, this afternoon sourceforge was down so I guessed that the file was there too. Mirror URL should be changed.
In my opinion, as it's a gtk-engines, it shouldn't install the metacity theme. It would be better to have another ebuild (e.g. clearlooks) that have this as dependency and that also install the metacity theme. What do you think about?
I had this thought, when engines and metacity themes come together but are separate packages it could be usefull to have a USE flag like metacity and gtk-engine (gnome-theme maybe for both) that trigger the metacity theme as a dep on gtk-engine and vice-versa. I understand that this intrudces a new USE flag but i think it could be really usefull for all the gtk-engine and metacity themes that belong to each other.
For simplicity's sake the metacity theme is just a text file. People are free not to use it by choosing another metacity theme. It introduces way too much hassle to separate them.
I just tried to digest gtk-engines-clearlooks/gtk-engines-clearlooks-0.5.ebuild . It got: !!! Couldn't download clearlooks-metacity-0.5.tar.gz. Aborting. What's wrong ?
Created attachment 54671 [details] gtk-engines-clearlooks-0.5.ebuild my mistake, use this one.
digests and emerges cleanly. Thanks a lot.
Created attachment 55846 [details] gtk-engines-clearlooks-0.5-r1.ebuild fixed header fixed indenting fixed keywords (works on x86, builds on amd64) metacity theme version is independent from gtk theme version
From the ChangeLog of gtk-engines-2.6.3: * Added Clearlooks engine and theme [Andrew Johnson, Thomas Wood]
Created attachment 56482 [details, diff] use Clearlooks metacity theme v0.5.2a
This isn't directly related to this bug, but what happened to the Clearlooks-Bluecurve theme? I really liked that. =(
Nevermind. I found that here: http://www.gnome-look.org/content/show.php?content=22577
The new ebuild removed the animated progress bars (via USE flag). Recovering that part of the ebuild worked for me.
Created attachment 57801 [details] gtk-engines-clearlooks-0.5-r2.ebuild added back the "animation" USE flag
Created attachment 57803 [details] gtk-engines-clearlooks-0.5-r3.ebuild A more elegant solution for USE-flag "animation"
Created attachment 57804 [details] gtk-engines-clearlooks-0.5-r4.ebuild A more elegant solution for USE-flag "animation"
Created attachment 58115 [details] gtk-engines-clearlooks-0.5-r5.ebuild I changed homepage and source uri for the metacity package.
Created attachment 60054 [details] Metadata for the package
Re: comment 46 - it is indeed a nifty technique but unfortunately ebuild authors are not supposed to set EXTRA_ECONF. As man 5 ebuild states, this variable is for users so I think we are not really supposed to set/overwrite that variable. Attaching an alternate ebuild (with bumped revision suffix as that trend appears to have caught on in this bug ;). On a different note, does anyone agree with me that the ebuild should just enable animation by default? It may be a hack, but it's a stable and aesthetically pleasing one and I'm not sure that we need YAUF (yet another USE flag) for it.
Created attachment 60340 [details] gtk-engines-clearlooks-0.5-r6.ebuild Similar to previous revision but does not set EXTRA_ECONF.
Yes, I too think the animated progress bar should be enabled by default. It not only looks nice but clearly indicates users that their computer is doing something, even if the progress bar moves slowly and rests for some time on a given value. Fedora und Ubuntu enable it by default.
Created attachment 60955 [details] gtk-engines-clearlooks/gtk-engines-clearlooks-0.6.ebuild just released version of clearlooks 0.6 based on the 0.5-r6 ebuild
version bump 0.6.1
Created attachment 61157 [details] gtk-engines-clearlooks-0.6.1.ebuild update for last version (0.6.1) simply rename the 0.6 ebuild
Created attachment 61655 [details, diff] gtk-engines-clearlooks-0.6.1-OO_crash_fix.patch this patch fixes a Ximian Openoffice crash with Clearlooks 0.6.1 that occurs when moving another window over an OO window. http://cvs.sourceforge.net/viewcvs.py/clearlooks/clearlooks/src/clearlooks_draw.c?rev=1.44&sortby=log&view=markup
Created attachment 61656 [details] gtk-engines-clearlooks-0.6.1-r1.ebuild modified ebuild (applies OO patch).
new clearlooks v0.6.2 already has OO patch, you simple rename gtk-engines-clearlooks-0.6.1.ebuild in gtk-engines-clearlooks-0.6.2.ebuild
renamed 0.6.1 to 0.6.2 and it works like charm.
Created attachment 63443 [details] Ebuild for 0.6.2 Renamed ebuild and removed the oo-patch
Created attachment 63681 [details] gtk-engines-clearlooks-0.6.2-r1.ebuild Install Clearlooks-Balloon and Clearlooks-Sharp metacity themes too.
Comment #41 pointed out that gtk-engines also includes clearlooks (as of 2.6.3). I notice that some other gtk-engines-* ebuilds which are duplicated in gtk-engines have dependency logic that seems to prevent them from being installed simultanesouly with gtk-engines (see x11-themes/gtk-engines, x11-themes/gnome-themes, x11-themes/gtk-engines-smooth, for example). Is it safe to install this new gtk-engines-clearlooks ebuild in parallel with gtk-engines-2.6.3? If not, this ebuild may need some dependency logic to reflect that.
It is save as in "it works". However, installing this ebuild overwrites files from gtk-engines-2.6.3 and it is gentoo/ebuild policy to not overwrite files belonging to an other package. Therefore this ebuild _should_ block >=x11-themes/gtk-engines-2.6.3! On a side note: Does somebody know how to fix these 'QA Notice: has_version() in global scope: eclass gtk-engines2'? Should have something to do with HAS_GTK2=1 in the ebuild. Anybody knows what to fix there?
/usr/lib/gtk-2.0/2.4.0/engines/libclearlooks.so /usr/lib/gtk-2.0/2.4.0/engines/libclearlooks.la The only two occurances I can find of any clearlooks files overwriting any GTK files. Possibly just not copy those files over when merging? FYI: [ebuild R ] x11-libs/gtk+-2.6.7 +doc +jpeg -static +tiff 0 kB
gtk-engines 2.6.3 has a bug that installs libclearlooks.{so,la} in the wrong location, and clearlooks included in gtk-engines is outdated, too. But Clearlooks will be the default theme in gnome 2.12, and actually there is a thread in gnome-devel mailing list about this overlapping, so I suggest waiting for an upstream solution. http://mail.gnome.org/archives/desktop-devel-list/2005-July/msg00436.html
Looks like a separate ebuild for clearlooks won't be needed after all. According to that thread linked in comment #65 (and the maintainer's post at http://blogs.gnome.org/view/thos/2005/07/27/0 ) Clearlooks is now officially a part of gtk-engines. It also installs to the correct place, too.
Thanks for all your contributions. However, as you know, gtk-engines is providing the clearlooks engine now, so we won't create separate ebuilds for it.
*** Bug 102673 has been marked as a duplicate of this bug. ***
*** Bug 103087 has been marked as a duplicate of this bug. ***
