Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 79294 - etc-update usability enhancement
Summary: etc-update usability enhancement
Status: RESOLVED WORKSFORME
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-23 23:59 UTC by mathias stearn
Modified: 2006-07-19 03:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Addresses the 3rd point (etc-update,10.42 KB, application/octet-stream)
2005-09-13 17:46 UTC, michael bowerman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mathias stearn 2005-01-23 23:59:09 UTC
I think etc-update is a great tool, I just think there were some minor oversights:

1) Support of app-misc/colordiff
I think that be default, colordiff should be used by etc-update as there are few who this would cause problems for. I suppose you could have a nocolor use flag for them. I cant imagine a situation where one would want this, but I guess someone might object.

2) Only list the original file names, not the new ones.
That would make it easier to visually group files based on their directory. For example, I almost never have etc-update do anything to the files update files in /etc/conf.d/ while I almost always leave the files in /etc/init.d/ for -5 autoupdating at the end

3) Modifying the description for -3 and -5
My suggestions:
-3: Use newer files prompting before replacing each older file
-5: Replace all older files with the newer ones without prompting.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Daniel Black (RETIRED) gentoo-dev 2005-01-24 03:26:19 UTC
1 /etc/dispatch-conf.conf controls what happens.
Comment 2 michael bowerman 2005-09-13 17:46:15 UTC
Created attachment 68415 [details]
Addresses the 3rd point

I think the decision to use colordiff as default would have to be made by
someone higher up in development.  According to the colordiff webpage [1],
Debian has moved to colordiff by default.  However, it is possible to change
this line: diff_command="diff -uN %file1 %file2" to diff_command="colordiff -uN
%file1 %file2" (or vimdiff, or whateverelse).

Restating the -3 and -5 options is a very good idea.  It's confusing for the
beginner and ambiguous for the experienced user.  Attached is an etc-update
script with the suggested changes.

I didn't have time to troubleshoot the version with the changes about listing
only one name.	But, I'll submit an updated version the next time I emerge.


[1] http://colordiff.sourceforge.net/
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2006-07-19 03:51:13 UTC
1) you can use colordiff, it's just not the default (not going to change that)
2) done for some time now
3) doesn't sound any clearer to me than the existing description ("older" and "newer" are dubious in this context).