Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 79201 - inappropriate use of gif useflag in mplayer ebuild
Summary: inappropriate use of gif useflag in mplayer ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-23 05:23 UTC by Stefan Sperling
Modified: 2005-01-23 06:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Sperling 2005-01-23 05:23:30 UTC 
(This bug report could be viewed as a followup to bug #16288)

If use gif is set, the ebuild depends on media-libs/libgif.
quote:
	gif? ( media-libs/giflib )

If use !gif is set, the ebuild depends on media-libs/libungif.
quote:
	!gif? ( media-libs/libungif )

I wonder why gif support is added at all if use !gif is set.

There should rather be a lwz useflag that determines whether to use
libgif or libungif, instead of using the gif useflag for this purpose.
Comment 1 Jan Brinkmann (RETIRED) gentoo-dev 2005-01-23 05:54:22 UTC 
this is fixed in mplayer-1.0_pre6:

  23 Jan 2005; Chris White <chriswhite@gentoo.org>
  mplayer-1.0_pre5-r5.ebuild, mplayer-1.0_pre6.ebuild:
  Fixed bug #78209. Also removed the gif lib logic in pre6 as it's no longer
  required (fixed upstream) and now gif is a true enable/disable style flag.
Comment 2 Stefan Sperling 2005-01-23 06:08:58 UTC 
Wow, that was quick :)