Bug 79196 – cvs.eclass depends on app-admin/sudo without using it

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Emil Beinroth 2005-01-23 04:38:56 UTC]

From cvs.eclass:
<snip>
# ECVS_RUNAS
#
# Specifies an alternate (non-root) user to use to run cvs.  Currently
# b0rked and wouldn't work with portage userpriv anyway without
# special magic.

# [ -z "$ECVS_RUNAS" ] && ECVS_RUNAS="`whoami`"
...
# add cvs to deps
# ssh is used for ext auth
# sudo is used to run as a specified user
DEPEND="$DEPEND dev-util/cvs app-admin/sudo"
...
    # It would be easiest to always be in "run-as mode", logic-wise,
    # if sudo didn't ask for a password even when sudo'ing to `whoami`.

    if [ -z "$ECVS_RUNAS" ]; then
        run=""
    else
        run="sudo -u $ECVS_RUNAS"
    fi
</snip>

app-admin/sudo should only be in DEPEND if $ECVS_RUNAS is not empty.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Portage 2.0.51-r14 (default-linux/x86/2004.3, gcc-3.4.3,
glibc-2.3.4.20041102-r0, 2.6.9-gentoo-r13 i686)
=================================================================
System uname: 2.6.9-gentoo-r13 i686 AMD Athlon(tm) XP 2600+
Gentoo Base System version 1.6.8
Python:              dev-lang/python-2.3.4 [2.3.4 (#1, Jan 14 2005, 05:37:52)]
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
dev-lang/python:     2.3.4
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.8.5-r2, 1.5, 1.4_p6, 1.6.3, 1.7.9, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r2
sys-devel/libtool:   1.5.10-r3
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer -mfpmath=sse
-fforce-addr -frerun-cse-after-loop -frerun-loop-opt -falign-functions=4
-maccumulate-outgoing-args -ffast-math -fprefetch-loop-arrays"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer -mfpmath=sse
-fforce-addr -frerun-cse-after-loop -frerun-loop-opt -falign-functions=4
-maccumulate-outgoing-args -ffast-math -fprefetch-loop-arrays"
DISTDIR="/usr/local/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms userpriv"
GENTOO_MIRRORS="http://mirrors.sec.informatik.tu-darmstadt.de/gentoo
ftp://linux.rz.ruhr-uni-bochum.de/gentoo-mirror
http://www.ibiblio.org/pub/Linux/distributions/gentoo "
MAKEOPTS="-j5"
PKGDIR="/usr/local/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/bmg-gnome-current
/usr/local/portage/bmg-main /usr/local/portage/gentoo-de
/usr/local/portage/deltup /usr/local/portage/local"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="x86 3dnow X alsa apm attr avi bash-completion bitmap-fonts cdr chroot crypt
cups directfb divx4linux doc encode f77 fbcon flac font-server foomaticdb
fortran gd gdbm gtk gtk2 guile hyriand imagemagick imap imlib imlib2 ithreads
java jpeg libg++ libwww mad matroska mbox mikmod mmx motif mpeg ncurses nfs nntp
nptl nptlonly offensive oggvorbis opengl oss pam pdflib perl png python
quicktime readline reiserfs samba sasl sdl slang spell sse ssl svga tcpd threads
tiff truetype truetype-fonts type1-fonts userlocales xml xml2 xmms xv xvid zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LDFLAGS

[Comment 1 Emil Beinroth 2005-01-23 04:41:10 UTC]

Created attachment 49268 [details, diff]
Only add app-admin/sudo to DEPEND if it is needed

[Comment 2 Jakub Moc (RETIRED) 2005-09-21 15:54:03 UTC]

Re-assign, assignee seems retired (Bug 106726).

[Comment 3 SpanKY 2005-09-21 16:23:05 UTC]

looks good, now in portage, thanks