If emerging keepassxc-2.6.4-r2 w/ USE="keeshare" with the actual included patch keepassxc-2.6.4-quazip1.patch then quazip won't be found and the keeshare-feature will be disabled. [emerge output] ... -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found Readline: /usr/include CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to `find_package_handle_standard_args` (QUAZIP) does not match the name of the calling package (QuaZip). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake/FindQuaZip.cmake:24 (find_package_handle_standard_args) src/keeshare/CMakeLists.txt:25 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. -- Could NOT find QUAZIP (missing: QUAZIP_INCLUDE_DIR) -- KeeShare: Secure container support is DISABLED; quazip library not found -- Including translations... -- Enabled features: * Auto-Type, Automatic password typing * Networking, Compile KeePassXC with network access code (e.g. for downloading website icons) * KeePassXC-Browser, Browser integration with KeePassXC-Browser * SSHAgent, SSH agent integration compatible with KeeAgent * KeeShare, Sharing integration with KeeShare (requires quazip5 for secure containers) * YubiKey, YubiKey HMAC-SHA1 challenge-response * FdoSecrets, Implement freedesktop.org Secret Storage Spec server side API. -- Disabled features: * UpdateCheck, Automatic update checking ... [/emerge output] Reproducible: Always Steps to Reproduce: 1. emerge keepassxc w/ USE="keeshare" 2. open database in keepassxc with shares (imports/exports/whatever) 3. keepassxc can't import/export keeshares because of disabled feature keeshre Actual Results: cmake does not find quazip so keeshare is disabled. Expected Results: quazip must be found and keeshare should be enabled after installation The patchfile keepassxc-2.6.4-quazip1.patch seems to be out of date. In line 25 there should be a reference to QuaZip-Qt5-1.1/quazip instead of QuaZip-Qt5-1.0/quazip, after manually changing this keepassxc compilations works as expected and the keeshare feature is enabled again. --- keepassxc-2.6.4-quazip1.patch 2021-02-23 21:09:18.000000000 +0100 +++ keepassxc-2.6.4-quazip1.1.patch 2021-05-25 13:52:09.560248674 +0200 @@ -22,7 +22,7 @@ find_path(QUAZIP_INCLUDE_DIR quazip.h PATHS /usr/include /usr/local/include - PATH_SUFFIXES quazip5 quazip -+ PATH_SUFFIXES quazip5 quazip QuaZip-Qt5-1.0/quazip ++ PATH_SUFFIXES quazip5 quazip QuaZip-Qt5-1.1/quazip ) find_path(QUAZIP_ZLIB_INCLUDE_DIR zlib.h PATHS /usr/include /usr/local/include) endif()
I guesss they never actually accepted the PR...
I don't like this situation. Honestly, this would require manual change of the patch each time quazip comes with a new release... Why can't people simply use pkgconfig? @boris64: Not your fault of course and I'm truely grateful that you filed this bug and provided a quick fix.
(In reply to Lars Wendler (Polynomial-C) from comment #2) > I don't like this situation. Honestly, this would require manual change of > the patch each time quazip comes with a new release... > > Why can't people simply use pkgconfig? > > @boris64: Not your fault of course and I'm truely grateful that you filed > this bug and provided a quick fix. Since https://github.com/keepassxreboot/keepassxc/pull/6560 has made it into keepass-2.6.5 (which is in portage now) i'd consider this bug as worksforme/fixed. @Polynomial-C Thanks ;)
You're welcome :)
