Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 79176 - Genkernel doesn't include supporting source files for --lvm2
Summary: Genkernel doesn't include supporting source files for --lvm2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-22 22:33 UTC by Stephen Ulmer
Modified: 2005-03-30 07:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Adds additional config file support (badly) (genkernel.diff,987 bytes, patch)
2005-01-25 13:10 UTC, Stephen Ulmer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Ulmer 2005-01-22 22:33:00 UTC
Genkernel seems to come with (included in the source tarball) diet-libc, busybox, udev, devfs, et al. Each with the correct version listed in the default config file.  It does *not* include LVM2 or device-mapper, though it now has an --lvm2 option.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




I care because I want to pass --lvm2 to genkernel from catalyst, but I've got no
way to get the LVM2 and device-mapper source files into the chroot'd environment
during the livecd-stage2 build.
Comment 1 Tim Yamin (RETIRED) gentoo-dev 2005-01-23 14:17:46 UTC
We don't provide source as that would make a really bulky distribution package. Either emerge lvm in the chroot that runs genkernel *or* edit /etc/genkernel.conf and change the tarball specification there.

Leaving bug open to get this documented...
Comment 2 Stephen Ulmer 2005-01-23 21:04:05 UTC
I don't believe there is a way to update the genkernel.conf from a catalyst spec file, maybe I should open a catalyst bug?

I'd actually be happier with the genkernel ebuild fetching *all* of the source tarballs required by the default genkernel.conf from a distfiles mirror at merge-time. That would make for a very small source distribution. Why include *any* of them in the genkernel distribution?
Comment 3 Tim Yamin (RETIRED) gentoo-dev 2005-01-25 08:56:38 UTC
> Why include *any* of them in the genkernel distribution?

Since they're guaranteed to work and are patched e.g. with cryptoloop support for busybox and other things needed for LiveCDs to work as they do.
Comment 4 Stephen Ulmer 2005-01-25 12:08:23 UTC
> Since they're guaranteed to work and are patched e.g. with cryptoloop support for busybox and other things needed for LiveCDs to work as they do.

I can respect that judgement call, but I think the argument is weak. You could easily fetch already-patched sources for some of the tools, and pristine sources for others.

How about a command-line option to use a different file for genkernel.conf?

Then I can at least accomplish something by using livecd/gk_mainargs and the new genkernel option. Or better yet, I can lobby for livecd/<kernelname>/genkernelconfig and let catalyst pass the option for me.
Comment 5 Stephen Ulmer 2005-01-25 12:25:12 UTC
Okay, looking at the genkernel script it seems that genkernel.conf actually tells genkernel where to locate the rest of it's parts -- making the genkernel.conf very dependent on the version of genkernel.

The before-suggested command-line option could be to source another "config" file after most of the genkernel modules are source'd. Thus re-defining only the variables the user wants to change -- almost like a config overlay.
Comment 6 Stephen Ulmer 2005-01-25 13:10:40 UTC
Created attachment 49506 [details, diff]
Adds additional config file support (badly)

Patch against 3.1.0c (applies to 3.1.0e). Trivially adds --config= option to
source an additional file containing variable assignments.

The maintainers may want to change the name of the option and variables.
Comment 7 Tim Yamin (RETIRED) gentoo-dev 2005-01-31 11:48:04 UTC
Ok, I think the best solution to this would be to get Portage to fetch these source tarballs if you have +lvm2 set in USE when you merge genkernel... How does that sound?
Comment 8 Chris Gianelloni (RETIRED) gentoo-dev 2005-01-31 12:21:30 UTC
I think having the ebuild pull in its sources is a much better way to go about it.

Personally, I would change the ebuild to do this for all sources.  We could store our pre-patched sources on our mirrors individually, rather than packaging them up into the genkernel tarball.

This way, it is easier to add/remove features via USE flags and other such things without having to roll a new genkernel tarball each time.
Comment 9 Stephen Ulmer 2005-02-02 13:20:07 UTC
I'd be ecstatic with the ebuild-fetches-the-sources solution (see comment #2 ;).

Comment 10 Tim Yamin (RETIRED) gentoo-dev 2005-03-30 07:09:45 UTC
3.1.1b and 3.1.5 both do this; closing bug as fixed.