Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 787017 - dev-vcs/git: missing runtime dependency for cvsimport
Summary: dev-vcs/git: missing runtime dependency for cvsimport
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-04-30 00:32 UTC by Nekun
Modified: 2021-05-10 20:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nekun 2021-04-30 00:32:54 UTC
git-cvsimport calls rsh for fetching from remote CVSROOT (https://git.kernel.org/pub/scm/git/git.git/tree/git-cvsimport.perl#n369) if it's not overrided by CVS_RSH, so we need to add net-misc/netkit-rsh to RDEPEND.
Comment 1 Nekun 2021-04-30 00:41:54 UTC
Created PR: https://github.com/gentoo/gentoo/pull/20607
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-05-10 18:02:32 UTC
I doubt this is necessary to be a hard dependency when USE="cvs" is set. I used git-cvsimport multiple times without rsh being installed on my system.

I suggest to add a conditional pkg_postinst message informing users about possible rsh necessity instead.
Comment 3 Nekun 2021-05-10 20:28:43 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #2)
> I doubt this is necessary to be a hard dependency when USE="cvs" is set. I
> used git-cvsimport multiple times without rsh being installed on my system.
> 
> I suggest to add a conditional pkg_postinst message informing users about
> possible rsh necessity instead.

Please note that rsh invokes only when ':ext:' protocol is used, and as I can see, this invocation was implemented in git starting from initial revision: https://git.kernel.org/pub/scm/git/git.git/commit/?id=34155390a576d8124e0adc864aaf2f11bbf5168b. Consider it an apparent evidence.

I got an error while trying to clone the OpenBSD repo.
Comment 4 Nekun 2021-05-10 20:39:15 UTC
> I suggest to add a conditional pkg_postinst message informing users about possible rsh necessity instead.
Well, if we consider that RSH is actually dead this might be enough, but error while invoking a tool with default setup looks somewhat `unclear` to me. As an alternative approach, I can suggest adding CVS_RSH="ssh" as a good default to env.d, in addition to the pkg_postinst message.