Bug 78615 – imagemagick-6.1.8.8 fails to compile with USE=fpx

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexandre Rostovtsev (RETIRED) 2005-01-18 20:48:55 UTC]

imagemagick-6.1.8.8 has the following prototype for ImportQuantumPixels() :
MagickExport MagickBooleanType ImportQuantumPixels(Image *image,
  const QuantumType quantum,const size_t pad,unsigned char *destination)

In coders/fpx.c, we have (starting at line 974)

    p=AcquireImagePixels(image,0,y,image->columns,1,&image->exception);
    if (p == (const PixelPacket *) NULL)
      break;
    if (fpx_info.numberOfComponents == 1)
      (void) ImportQuantumPixels(image,GrayQuantum,pixels);
    else
      if (image->matte == MagickFalse)
        (void) ImportQuantumPixels(image,RGBQuantum,0,pixels);
      else
        (void) ImportQuantumPixels(image,RGBAQuantum,0,pixels);

For the grayscale case, the ImportQuantumPixels function is called with 3 arguments instead of 4; the pad argument is omitted. This error is also present in the latest CVS version of ImageMagick (checked out on Jan 18 2004). As far as I can see, everywhere else in ImageMagick source, the pad argument is set to 0 - however, I am a bit hesisitant to say if it should be set to 0 in this case also, since I am unfamiliar with ImageMagick internals.

Reproducible: Always
Steps to Reproduce:
1. ACCEPT_KEYWORDS=~x86 USE=fpx emerge -av imagemagick

Actual Results:  
if /bin/sh ./libtool --silent --tag=CC --mode=compile i686-pc-linux-gnu-gcc
-DHAVE_CONFIG_H -I. -I. -I./magick   -I/usr/include/freetype2
-I/usr/X11R6/include -I/usr/X11R6/include/X11 -I/usr/include/graphviz
-I/usr/include/libxml2  -march=athlon-xp -O2 -pipe -frename-registers
-fomit-frame-pointer -Wall -pthread -MT coders/coders_jbig_la-jbig.lo -MD -MP
-MF "coders/.deps/coders_jbig_la-jbig.Tpo" -c -o coders/coders_jbig_la-jbig.lo
`test -f 'coders/jbig.c' || echo './'`coders/jbig.c; \
then mv -f "coders/.deps/coders_jbig_la-jbig.Tpo"
"coders/.deps/coders_jbig_la-jbig.Plo"; else rm -f
"coders/.deps/coders_jbig_la-jbig.Tpo"; exit 1; fi
coders/fpx.c: In function `WriteFPXImage':
coders/fpx.c:978: warning: passing arg 3 of `ImportQuantumPixels' makes integer
from pointer without a cast
coders/fpx.c:978: error: too few arguments to function `ImportQuantumPixels'
make[1]: *** [coders/coders_fpx_la-fpx.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory
`/var/tmp/portage/imagemagick-6.1.8.8/work/ImageMagick-6.1.8'
make: *** [all] Error 2

!!! ERROR: media-gfx/imagemagick-6.1.8.8 failed.

Expected Results:  
Successful compile

Portage 2.0.51-r13 (default-linux/x86/2004.3, gcc-3.4.3,
glibc-2.3.4.20041102-r0, 2.6.10-gentoo-r4 i686)
=================================================================
System uname: 2.6.10-gentoo-r4 i686 AMD Athlon(tm) XP 2500+
Gentoo Base System version 1.6.8
Python:              dev-lang/python-2.2.3-r5,dev-lang/python-2.3.4 [2.3.4 (#1,
Nov  9 2004, 13:07:05)]
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.2.3-r5, 2.3.4
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.8.5-r2, 1.5, 1.4_p6, 1.6.3, 1.7.9, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r2
sys-devel/libtool:   1.5.10-r2
virtual/os-headers:  2.6.8.1-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O2 -pipe -frename-registers -fomit-frame-pointer "
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown
/usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O2 -pipe -frename-registers -fomit-frame-pointer "

[Comment 1 Karol Wojtaszek (RETIRED) 2005-01-19 13:15:00 UTC]

There is already patch in portage, sync the tree and emerge again.