Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 78455 - gtk-qt-engine-0.6-r1 has wrong slot
Summary: gtk-qt-engine-0.6-r1 has wrong slot
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-17 18:28 UTC by James Roberts-Thomson
Modified: 2006-01-26 05:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix SLOT issue (gtk-qt-engine-0.6-r1.patch,616 bytes, patch)
2005-01-17 18:31 UTC, James Roberts-Thomson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Roberts-Thomson 2005-01-17 18:28:38 UTC
The gtk-qt-engine-0.6-r1 ebuild has the wrong SLOT, as shown here:

# etcat -v gtk-qt-engine
[ Results for search key           : gtk-qt-engine ]
[ Candidate applications found : 3 ]

 Only printing found installed programs.

*  x11-themes/gtk-qt-engine :
        [ ~ ] 0.5 (2)
        [  I] 0.6 (2)
        [  I] 0.6-r1 (0)

As can be seen, both 0.6 and 0.6-r1 are installed due to this SLOT error.  The ebuild does set SLOT="2", but this seems to be overridden by something else.

Reproducible: Always
Steps to Reproduce:




Expected Results:  
emerging gtk-qt-engine-0.6-r1 should cause gtk-qt-engine-0.6 to be removed as
part of the autoclean.
Comment 1 James Roberts-Thomson 2005-01-17 18:31:07 UTC
Created attachment 48806 [details, diff]
Patch to fix SLOT issue

This patch (which only moves the "need-kde 3" line) is enough to fix the SLOT
issue - I guess somehow the "need-kde" function is clearing the SLOT setting.
Comment 2 Gregorio Guidi (RETIRED) gentoo-dev 2005-01-19 04:57:21 UTC
At the moment our eclasses force SLOT to be 0 for non kde-base ebuilds, should we change that, or we just allow SLOT to be overridden after need-kde() has been called?
Comment 3 Dan Armak (RETIRED) gentoo-dev 2005-01-21 12:06:09 UTC
First of all the patch to the ebuild should be applied - can someone who has
it emerged do that? motaboy?
===============
need-kde() sets SLOT=0 for non-kdebase ebuilds. But kde.eclass already sets
SLOT=0 (unconditionally) in its global section. Therefore the former should be
removed - AFAICS nothing would break. But when changing such a central
function, I want to day to reflect to make sure nothing is broken :-)
OK to commit?
Comment 4 Simone Gotti (RETIRED) gentoo-dev 2005-01-21 12:20:34 UTC
I've fixed the ebuild keeping the call to "need-kde" in the same place (after DEPEND as should be) but setting SLOT=2 after it.
Comment 5 Caleb Tennis (RETIRED) gentoo-dev 2006-01-26 05:36:50 UTC
Looks to be fixed to me.