Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 784218 - livecd-stage2.spec: Give users more control over livecd/gk_mainargs
Summary: livecd-stage2.spec: Give users more control over livecd/gk_mainargs
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: Catalyst (show other bugs)
Hardware: All Linux
: Highest major (vote)
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords: EBUILD, Inclusion, PATCH
Depends on:
Blocks:
 
Reported: 2021-04-19 19:00 UTC by Kenneth G. Strawn
Modified: 2021-08-27 01:55 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to kmerge.sh to fix this (0001-Give-the-user-more-control-over-genkernel.patch,1003 bytes, patch)
2021-04-19 19:02 UTC, Kenneth G. Strawn
Details | Diff
.spec file that triggers this bug (livedvd-stage2.spec,1.05 KB, text/plain)
2021-04-19 19:37 UTC, Kenneth G. Strawn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth G. Strawn 2021-04-19 19:00:50 UTC
Attempting to specify the "kernel" option instead of "all" in livecd-stage2.spec/livecd/gk_mainargs doesn't do anything.

Reproducible: Always

Steps to Reproduce:
1. Add "livecd/gk_mainargs: --kernel-config=/etc/kernels/defconfig --kernel-config-filename=defconfig --callback=dracut\\ \-\-force kernel" to the .spec file
2. Attempt to build
Actual Results:  
Catalyst injects "all" into the command string automatically, screwing up the build

Expected Results:  
Should allow the use of genkernel to build the kernel and dracut to build the initramfs because genkernel builds the actual kernel and dracut doesn't while dracut supports Plymouth and "genkernel initramfs" doesn't.

Attaching a patch after this is reported because there's no option to do so on the initial form.
Comment 1 Kenneth G. Strawn 2021-04-19 19:02:23 UTC
Created attachment 700896 [details, diff]
Patch to kmerge.sh to fix this

Instead of "all" there's a comment about letting the user do what he or she wants.
Comment 2 Kenneth G. Strawn 2021-04-19 19:37:09 UTC
Created attachment 700902 [details]
.spec file that triggers this bug

Note the livecd/gk_mainargs line.
Comment 3 Kenneth G. Strawn 2021-04-19 22:45:41 UTC
I would strongly suggest adding "all" to the livecd/gk_mainargs on all official proj/releng.git spec files to compensate for this.
Comment 4 Kenneth G. Strawn 2021-04-20 18:28:39 UTC
Submitted a series of pull requests to the GitHub mirror to fix this:

https://github.com/gentoo/catalyst/pull/7

https://github.com/gentoo/releng/pull/6

Now all they have to be is merged in.
Comment 5 Kenneth G. Strawn 2021-04-20 18:35:03 UTC
(In reply to Kenneth G. Strawn from comment #4)
> Submitted a series of pull requests to the GitHub mirror to fix this:
> 
> https://github.com/gentoo/catalyst/pull/7
> 
> https://github.com/gentoo/releng/pull/6
> 
> Now all they have to be is merged in.

Fixing this bug by merging these pull requests would clear the only hurdle that's standing in the way of bringing back the Live DVD.
Comment 6 Ben Kohler gentoo-dev 2021-04-20 18:36:39 UTC
We're already unofficially rolling new LiveDVDs without these patches, FYI.
Comment 7 Kenneth G. Strawn 2021-08-26 18:50:53 UTC
Obsoleting in favor of bug 785754 which offers a much better, much easier-to-implement solution (and also has a patch attached).