Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 7833 - net-www/mozilla-1.1-r2.ebuild (better useflag testing)
Summary: net-www/mozilla-1.1-r2.ebuild (better useflag testing)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High trivial (vote)
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-12 09:05 UTC by Paul Belt
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Belt 2002-09-12 09:05:55 UTC
188a189,204
>       if [ -n "`use ipv6`" ]; then
>               myconf="${myconf} --enable-ipv6"
>       fi
> 
>       if [ -n "`use crypt`" ]; then
>               myconf="${myconf} --enable-crypto"
>       fi
> 
>       if [ -n "`use java`" ]; then
>               myconf="${myconf} --with-java-supplement"
>       fi
> 
>       if [ -n "`use zlib`" ]; then
>               myconf="${myconf} --with-system-zlib"
>       fi
> 
195,196d210
<               --with-system-zlib \
<               --enable-ipv6 \
198d211
<               --enable-crypto \
201d213
<               --with-java-supplement \
Comment 1 Paul Belt 2002-09-12 09:09:53 UTC
http://www.mozilla.org/releases/mozilla1.0.1/security-fixes-1.0.1.html

Bumpt mozilla-1.0 ASAP, please.
Comment 2 Paul Belt 2002-09-12 09:13:15 UTC
Opps.  Remove the -n's   This patch applies to mozilla-1.1-r1.ebuild
Comment 3 Paul Belt 2002-09-12 09:17:02 UTC
And here's the one to bump mozilla-1.0-r3 to mozilla-1.0.1

203a204,219
>       if [ "`use ipv6`" ] ; then
>               myconf="${myconf} --enable-ipv6"
>       fi
> 
>       if [ "`use crypt`" ] ; then
>               myconf="${myconf} --enable-crypto"
>       fi
> 
>       if [ "`use zlib`" ] ; then
>               myconf="${myconf} --with-system-zlib"
>       fi
> 
>       if [ "`use java`" ] ; then
>               myconf="${myconf} --with-java-supplement"
>       fi
> 
210,211d225
<               --with-system-zlib \
<               --enable-ipv6 \
213d226
<               --enable-crypto \
216d228
<               --with-java-supplement \
Comment 4 Paul Belt 2002-09-12 09:49:32 UTC
More mozilla-1.0.1.ebuild patching.  I have to wait for it to finish compiling
before I can test.

72c72,74
<       patch -p1 < ${FILESDIR}/mozilla-new-freetype2.patch || die
---
> 
>       # Not needed for 1.0.1?
>       #patch -p1 < ${FILESDIR}/mozilla-new-freetype2.patch || die
77c79
<               patch -p1 < ${FILESDIR}/${P}-asmfixes.patch || die
---
>               patch -p1 < ${FILESDIR}/${PN}-1.0-asmfixes.patch || die
88c90
<                       patch -p0 < ${FILESDIR}/${P}-abi-compat-wrappers.patch
---
>                       patch -p0 < ${FILESDIR}/${PN}-1.0-abi-compat-wrappers.patch
Comment 5 Paul Belt 2002-09-12 09:52:41 UTC
cc1: warning: ignoring command line option '-Wno-deprecated'
cc1: warning: (it is valid for C++ but not the selected language)

Line 233 of the ebuild '--enable-optimize="-Wno-deprecated -O3" \'

-Wno-deprecated should probably be removed
Comment 6 Martin Schlemmer (RETIRED) gentoo-dev 2002-09-12 14:11:47 UTC
For any 1.0 problems, odities .. they have been addressed in 1.1 ebuild, so
check there before you report.

Then for the rest, zlib is in the default system profile, so not using the
system zlib is only going to cause the buildin zlib to be compiled, and thus
a bit longer compile times.

ipv6 .. maybe, but dont see why it should not be used by default, as it does
not cause issues like in some other packages.

java .. is the bit of code more going to that a big issue for anybody other
than not being there for the new user ?

crypt .. this enables/disables the Personal Security Manager, which handles
stuff like encryption for banking, any secure sites, ssl, etc.  Once again,
wont it cause more damage then good not enabling by default ?  Also, is it
an issue in some countries ?  More info about crypts used can be found:

 http://www.mozilla.org/projects/security/pki/nss/algorithms.html


In general when changing big builds like glibc, mozilla, xfree, my first
questions are usually:

1) Can it influence stability ?
2) Can it cause discomfort ?

For a newbie on a p2 or even duron, compiling mozilla, etc can be a long
wait, and thus I go with the orientation that we enable the most common
used features by default as to avoid problems.

Secondly, using system zlib, or internal zlib for instance, can have a big
impact on stability.  I thus do not want to have the possible failures even
bigger with too many ways big build can be done.

For the more advanced user ... portage-local feature is in place now, and
most of us edit things to suite our needs anyhow ...
Comment 7 Paul Belt 2002-09-13 00:03:13 UTC
Just something I noticed when reading /. earlier with the 1.0.1 security thing.
 I said something to seemant and he stated to submit a bug report.  Close it if
ye wish.  You are the mozilla guru.  Not I.