Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 78216 - kde-meta.eclass: hardcoded lib/ directories
Summary: kde-meta.eclass: hardcoded lib/ directories
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-16 07:06 UTC by Tom Martin (RETIRED)
Modified: 2005-02-16 10:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kde-meta-libdir.patch (kde-meta-libdir.patch,1.15 KB, patch)
2005-02-12 10:13 UTC, Gregorio Guidi (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Martin (RETIRED) gentoo-dev 2005-01-16 07:06:25 UTC
On line 317 of kde-meta.eclass, there is a call to find with a hardcoded lib/. This should be replaced by $(get-libdir), otherwise many kde-base packages won't install on a fully multilib'd system. Also, the find call does not have some kind of path as first argument so it is not portable to other systems. (e.g. find . -name asdf rather than find -name asdf).

Thanks.
Comment 1 Dan Armak (RETIRED) gentoo-dev 2005-01-17 07:51:13 UTC
It does have a path. That lib/ is the path, being the first argument to find.

Sorry about my multilib ignorance, but where does get-libdir come from?
There's no such beast on my (non-multilib, of course) system AFAICS.

Is there an enlightening doc on multilib stuff somewhere? I don't know what kde
would look like on such a system.
Comment 2 Tom Martin (RETIRED) gentoo-dev 2005-01-17 10:42:41 UTC
get-libdir is in multilib.eclass, but sorry about mixing up the find stuff, I had a bit of a brain lapse :)
Comment 3 Gregorio Guidi (RETIRED) gentoo-dev 2005-02-12 10:13:06 UTC
Created attachment 51069 [details, diff]
kde-meta-libdir.patch

Should we apply something like this, then?
Comment 4 Tom Martin (RETIRED) gentoo-dev 2005-02-16 08:25:38 UTC
That looks fine, thanks Greg.
Comment 5 Gregorio Guidi (RETIRED) gentoo-dev 2005-02-16 10:01:15 UTC
Ok, it's committed now.