Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 78026 - mail-filter/spamassassin: Add optional dependencies on stuff needed to enable extra tests
Summary: mail-filter/spamassassin: Add optional dependencies on stuff needed to enable...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-14 15:41 UTC by Torne Wuff
Modified: 2005-11-11 12:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add extra dependencies for more tests (spamassassin-manytests.diff,629 bytes, patch)
2005-01-14 15:42 UTC, Torne Wuff
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torne Wuff 2005-01-14 15:41:03 UTC
There are a number of extra packages that are useful in a SpamAssassin installation, detailed in INSTALL.gz - the existing ebuild mentions their existence, but doesn't help you install them (not all the ebuilds have the name of the package given in the docs, fex. IP::Country::Fast is in dev-perl/IP-Country). The attached patch adds a USE flag that will pull in all these extra dependencies for people who want a relatively 'complete' SA install.
Comment 1 Torne Wuff 2005-01-14 15:42:08 UTC
Created attachment 48517 [details, diff]
Patch to add extra dependencies for more tests
Comment 2 Malte S. Stretz 2005-01-16 11:17:25 UTC
A USE flag for all that stuff is the wrong solution here (though if eg. "spf" became a global flag one day, we could add it).

Maybe an einfo mentioning dev-perl/Mail-SPF-Query, dev-perl/IP-Country, mail-filter/razor, mail-filter/dcc and dev-python/pyzor at the end of the merge process would be a sane solution.  

Time::HiRes is part of Perl 5.8.5 BTW.  And why did you add libnet?
Comment 3 Torne Wuff 2005-01-17 05:27:34 UTC
There's an einfo at present which mentions reading INSTALL.gz for optional modules; a more specific one listing the exact packages would be helpful, yeah.

I'm not convinced that it's wrong to have a USE.. I submitted this after spending some time trying to track down just why some of the entries in my world file were present (dev-perl/IP-Country stumped me for a while..). My argument would be that I don't have a specific desire to have these pieces of software installed; Razor, Pyzor, DCC, etc would be no use to me without SpamAssassin to 'drive' them; so they logically should be dependencies of SA, in my mind..

What I'm looking for is something analogous to Debian's Recommends: or Suggests: dependencies, for packages that are not required, but will enhance the functionality of the parent package. I thought a USE flag was the right way to do this. Simply telling the user to install something else as well doesn't record the 'dependency', even if it's not a hard requirement.

Whoops re Time::HiRes; I had it installed on my machine from before it was in perl... likewise for libnet (it provides Net::SMTP which SA uses to submit spam to SpamCop). Both of those can be dropped, if this isn't discarded entirely.

It's not up to me, but I expected to see a USE flag for the extra tests, and was disappointed by the expectation that I manually install a whole bunch of things in order to get full functionality from SA..
Comment 4 Nathan Toone 2005-03-02 11:11:52 UTC
what about a use flag for dcc, a use flag for razor and a use flag for pyzor?  Those seem like valid use flags...
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2005-09-04 04:12:17 UTC
Mass re-assign.
Comment 6 Michael Cummings (RETIRED) gentoo-dev 2005-11-11 12:23:55 UTC
Fixed in version about to hit portage - all of these flags are now real use flags.