Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77803 - Several KPPP issues in kdenetwork-3.3.1-r1 and below
Summary: Several KPPP issues in kdenetwork-3.3.1-r1 and below
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-13 03:24 UTC by spiritus
Modified: 2005-01-19 08:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description spiritus 2005-01-13 03:24:02 UTC
1.
Once I've found that the MTU value set in /etc/ppp/options/options.ttyS1 ignored in the case of KPPP use. After following research I've found the reason - KPPP doesn't add serial device name in the ppp lauch string.  That's why pppd laucnhed by KPPP totally ignores /etc/ppp/options/ttySx.
I suggest following patch to fix the bug to bring correct KPPP behavior back:

--- kdenetwork-3.3.1/kppp/connect.cpp   2004-05-23 02:57:27.000000000 +0600
+++ ../connect.cpp      2005-01-13 15:14:47.380257000 +0500
@@ -1247,8 +1247,8 @@
   // opening a device given in a command line. To avoid permission conflicts
   // we'll simply leave this argument away. pppd will then use the default tty
   // which is the serial port we connected stdin/stdout to in opener.cpp.
-  //  command += " ";
-  //  command += gpppdata.modemDevice();
+  command += " ";
+  command += gpppdata.modemDevice();

   command += " " + gpppdata.speed();

Although there are warning in the code telling why the code was commented but I see no reason to have that code commented out. I have patched my own KPPP and use it for about month without any troubles such as 'permission conflicts'.

2.
Optionaly I suggest patch to allow KPPP automatic redialing on 'NO DIAL TONE' and 'NO CARRIER' modem answers if 'Redial on NO CARRIER' checkbox selected. Such KPPP behaviour allows continious redialing on disconnects. The reason to redial on 'NO DIAL TONE' and 'NO CARRIR' is that on some poor quality lines(such as mine dialup) modem gives 'NO CARRIER' and 'NO DIAL TONE' responses time to time. With the current behavior in the case of 'NO DIAL TONE' modem responce, KPPP stops redialing and waits for manual redial. It's inconvinient. So here is my patch to allow fully continuous redialing KPPP if 'Redial on NO CARRIER' enabled:

--- connect.cpp 2004-05-23 02:57:27.000000000 +0600
+++ ../../../connect.cpp        2004-12-19 05:44:44.000000000 +0500
@@ -451,7 +451,9 @@
       return;
     }

-    if(readbuffer.contains(gpppdata.modemNoDialtoneResp())) {
+/*   NO DIAL TONE case behavior the same as NO CARRIER case by spiritus 12/19/2004   */
+
+/*    if(readbuffer.contains(gpppdata.modemNoDialtoneResp())) {
       timeout_timer->stop();

       messg->setText(i18n("No Dial Tone"));
@@ -460,8 +462,10 @@
       gpppdata.setWaitCallback(false);
       return;
     }
+*/

-    if(readbuffer.contains(gpppdata.modemNoCarrierResp())) {
+    if(readbuffer.contains(gpppdata.modemNoCarrierResp())||
+            readbuffer.contains(gpppdata.modemNoDialtoneResp())) {
       if (gpppdata.get_redial_on_nocarrier()) {
         timeout_timer->stop();
         timeout_timer->start(gpppdata.modemTimeout()*1000);

3.
There is some issue with the "LOG" button. Once "LOG" button pressed, debug log window pops up each time redial occurs while the "Show log window" unchecked.
Steps to reproduce the bug:
- Launch KPPP ('Show log window' unchecked)
- Press 'Connect' button
- Press LOG button while connect 
- Close log window
- Press 'Cancel' to cancel dialing
- Press 'Connect' button again. Log Window will pop up while 'Show log window' checkbox unchecked.
It's some kind of state desync between actual 'Show log window' variable state and 'Show log window' checkbox state.

Reproducible: Always
Steps to Reproduce:
Comment 1 Gregorio Guidi (RETIRED) gentoo-dev 2005-01-13 03:38:54 UTC
Good work, but you're asking the wrong person...
please submit these changes at http://bugs.kde.org
they're the only ones that can say if they can go in.

BTW: point 3 is already there: http://bugs.kde.org/show_bug.cgi?id=85351
Comment 2 Gregorio Guidi (RETIRED) gentoo-dev 2005-01-19 08:47:26 UTC
see previous comment.