Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77667 - gentoo-syntax should also mark trailing tabs
Summary: gentoo-syntax should also mark trailing tabs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-12 05:17 UTC by Michael Hanselmann (hansmi) (RETIRED)
Modified: 2005-01-30 11:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Screenshot to prove it (gentoo-syntax-error.png,4.09 KB, image/png)
2005-01-27 11:09 UTC, Michael Hanselmann (hansmi) (RETIRED)
Details
Example (example.ebuild.gz,189 bytes, application/octet-stream)
2005-01-27 11:29 UTC, Michael Hanselmann (hansmi) (RETIRED)
Details
My vimrc stripped of comments and really unrelated stuff (vimrc-hansmi,487 bytes, text/plain)
2005-01-27 11:36 UTC, Michael Hanselmann (hansmi) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-01-12 05:17:14 UTC
Currently, app-vim/gentoo-syntax does only mark trailing tabs. Trailing spaces shall also getting marked.
Comment 1 Ciaran McCreesh 2005-01-12 12:43:37 UTC
Hrm, got a test case?

if exists("g:ebuild_error_on_trailing_whitespace")
    syn match   EbuildError /^.*\s\+$/
endif

The \s should match all kinds of spaces.
Comment 2 Aaron Walker (RETIRED) gentoo-dev 2005-01-13 05:13:35 UTC
Using the following in my ~/.vimrc

let ebuild_error_on_trailing_whitespace=1

works for all whitespace here.
Comment 3 Ciaran McCreesh 2005-01-19 11:25:31 UTC
Mmmm, works for us. Please reopen if you have examples.
Comment 4 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-01-27 11:09:56 UTC
Created attachment 49677 [details]
Screenshot to prove it
Comment 5 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-01-27 11:11:07 UTC
I was able to reproduce it. But unfortunately, I got the summary wrong the last time. Trailing tabs should also be marked, not spaces. I've attached a screenshot using vim 6.3.58 (vim-6.3-r4) and gentoo-syntax-20041227. The two red lines are spaces, whose are highlighted correctly. Between them, there is a line of three tabs whose aren't highlighted. Hopefully, this can be fixed. Thank you!
Comment 6 Ciaran McCreesh 2005-01-27 11:19:27 UTC
Stiiiiiiill can't reproduce it. File please?
Comment 7 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-01-27 11:29:47 UTC
Created attachment 49679 [details]
Example

Added an example. It's just a random ebuild with added tabs and spaces.
Comment 8 Ciaran McCreesh 2005-01-27 11:33:29 UTC
Stiiiiiiiiiillll can't reproduce it. Do you have anything weird in your vimrc?
Comment 9 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2005-01-27 11:36:46 UTC
Created attachment 49680 [details]
My vimrc stripped of comments and really unrelated stuff

I've now attached my vimrc. Maybe it's really something in there. Or might it
be an architecture problem? (I'm using ~ppc)
Comment 10 Ciaran McCreesh 2005-01-30 11:25:03 UTC
let g:ebuild_error_on_trailing_whitespace=1

It's a feature :)