Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 774120 - Drop copyright headers in profiles/*
Summary: Drop copyright headers in profiles/*
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Council
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-04 01:00 UTC by Sam James
Modified: 2021-03-14 19:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-04 01:00:00 UTC
It's not clear any of these files in profiles/* are actually copyrightable.

I mentioned automatically adding headers for pkgdev (repoman replacement) in https://github.com/pkgcore/pkgdev/issues/11, but we ended up discussing about the need for the headers in the first place.

Could we just drop them?
Comment 1 Ulrich Müller gentoo-dev 2021-03-04 07:24:43 UTC
GLEP 76 says: "All copyrightable files included in Gentoo projects must contain appropriate copyright and license notices, as defined by this policy."

The comments in these files may very well be copyrightable.

$ find profiles -type f -exec wc {} + | tail -n1
 23612  97015 780821 total

I believe we'd have a hard time arguing that this is small and below the threshold or originality. Plus, it is arguably a database and may be protected by "sui generis database rights" in the EU:
https://en.wikipedia.org/wiki/Database_Directive

So, let's please stay on the safe side and keep the headers. These few lines don't harm, and we already omit the header from files that are obviously trivial (like eapi or parent).
Comment 2 Ulrich Müller gentoo-dev 2021-03-04 07:44:05 UTC
Also, we require a Signed-off-by line for every commit, which must refer to a license. When drafting GLEP 76, we considered lifting that requirement for files that are in the public domain, but decided that labelling such files with "CC0" or "CC Public Domain Mark" is preferable, in order to remove any doubt about their public domain status.

This is mentioned in https://www.gentoo.org/glep/glep-0076.html#id32 (last paragraph of the section).
Comment 3 Tim Harder gentoo-dev 2021-03-04 18:49:36 UTC
(In reply to Ulrich Müller from comment #1)
> GLEP 76 says: "All copyrightable files included in Gentoo projects must
> contain appropriate copyright and license notices, as defined by this
> policy."

This feels very haphazard since the headers aren't even applied to all files in a cohesive fashion. One reason might be that no editor syntax project currently auto-adds them when a developer creates a new file as is done for ebuilds using skel.ebuild.

> So, let's please stay on the safe side and keep the headers. These few lines
> don't harm, and we already omit the header from files that are obviously
> trivial (like eapi or parent).

Personally I'd call all the profiles/* trivial files, but if we want to go down that route... how come files in the base directory don't have headers? For example, I'm not seeing headers in arches.desc, info_*, and profiles.desc even when they have other comments in the header.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-04 20:06:57 UTC
What if someone writes a creative mask message? ;-)
Comment 5 Ulrich Müller gentoo-dev 2021-03-04 20:51:36 UTC
(In reply to Michał Górny from comment #4)
> What if someone writes a creative mask message? ;-)

OK, that's enough. Closing.
Comment 6 Tim Harder gentoo-dev 2021-03-04 21:58:26 UTC
Reopening because I'd like an actual response as to why Gentoo isn't applying this "standard" consistently across profiles/* then. Trivial searches show even files like package.mask aren't always prefixed with copyrights in every subdir.
Comment 7 Ulrich Müller gentoo-dev 2021-03-04 22:43:51 UTC
(In reply to Tim Harder from comment #6)
> Reopening because I'd like an actual response as to why Gentoo isn't
> applying this "standard" consistently across profiles/* then. Trivial
> searches show even files like package.mask aren't always prefixed with
> copyrights in every subdir.

I agree, we should be more consistent there. AFAICS, any file except "parent", "eapi", and "deprecated" (where PMS explicitly forbids comments) could have a standard header.

Arguably, a header won't be needed for very small files (e.g., the FSF draws the limit at 15 lines [1]). But adding them everywhere may be simpler, and then they won't be forgotten when a file is growing.

[1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html
Comment 8 Tim Harder gentoo-dev 2021-03-04 23:38:25 UTC
(In reply to Ulrich Müller from comment #7)
> I agree, we should be more consistent there. AFAICS, any file except
> "parent", "eapi", and "deprecated" (where PMS explicitly forbids comments)
> could have a standard header.
> 
> Arguably, a header won't be needed for very small files (e.g., the FSF draws
> the limit at 15 lines [1]). But adding them everywhere may be simpler, and
> then they won't be forgotten when a file is growing.
> 
> [1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html

Sounds fine.

I don't overly care what the mandate is, just if Gentoo expects a standard header consistency aids verification (pkgcheck) and automatically adding/updating them (pkgdev).
Comment 9 Andreas K. Hüttel archtester gentoo-dev 2021-03-14 19:21:02 UTC
Without a vote, the council tends to recommend just keeping the header / putting it in everywhere.