Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77235 - mplayer ebuilds do not support distcc feature
Summary: mplayer ebuilds do not support distcc feature
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-09 08:09 UTC by Jan Safrata
Modified: 2005-01-23 13:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Safrata 2005-01-09 08:09:47 UTC
Because plain make is used to compile mplayer in ebuild instead of emake, distcc feature is not used.

Could the following line in mplayer ebuild
  make all || die "Failed to build MPlayer!"

be replaced for example with
  make depend && emake || die "Failed to build MPlayer!"

please?

Thanks.
Comment 1 Jan Brinkmann (RETIRED) gentoo-dev 2005-01-09 08:14:22 UTC

*** This bug has been marked as a duplicate of 64749 ***
Comment 2 Jan Safrata 2005-01-09 08:25:48 UTC
This bug is not duplicate for #64749 - I do not have any problem compiling mplayer using -j4 distcc, it compiles just fine. But the original ebuilds discard -j4 make switch from MAKEOPTS simply because "make" is used instead of "emake" in the ebuild.

With following patch to the ebuild, mplayer compiles just fine using distcc feature. Could you, please, apply it?

*** mplayer-1.0_pre6.ebuild.orig        2005-01-09 07:37:25.000000000 +0100
--- mplayer-1.0_pre6.ebuild     2005-01-09 17:23:43.028049459 +0100
***************
*** 413,419 ****
        fi

        einfo "Make"
!       make all || die "Failed to build MPlayer!"
        einfo "Make completed"

        # We build the shared libpostproc.so here so that our
--- 413,419 ----
        fi

        einfo "Make"
!       make depend && emake || die "Failed to build MPlayer!"
        einfo "Make completed"

        # We build the shared libpostproc.so here so that our
Comment 3 Jan Brinkmann (RETIRED) gentoo-dev 2005-01-23 13:06:37 UTC
ok, sorry for closing it. i havn't read it good enough, my bad. changes made in mplayer-1.0_pre6. thanks for the report.