Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77184 - net-dialup/slmodem should stay on old version
Summary: net-dialup/slmodem should stay on old version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-08 16:38 UTC by Daniel Drake (RETIRED)
Modified: 2005-01-21 13:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
2.6.10 compatibility patch ([patch] amrmo_init.c for 2.6.10.eml,3.94 KB, patch)
2005-01-08 16:39 UTC, Daniel Drake (RETIRED)
Details | Diff
patches slmodem-2.9.9a/modem/modem_cmdline.c (slmodem-2.9.9a-alsa-device-patch.diff,907 bytes, patch)
2005-01-19 05:43 UTC, Jos Delbar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Drake (RETIRED) gentoo-dev 2005-01-08 16:38:29 UTC
The main developer for the slmodem linux drivers no longer works for smartlink. I do not know the reason for this.

slmodem-2.9.10 introduced a license change which makes it quite a bit more restrictive. I think we should stick to the older version (with BSD-like license) so that we can continue to provide it on livecds.

I'm guessing that it is likely we won't see another slmodem release for a while now that Sasha is gone. The linmodems developers have picked up maintenance of the last "free" version (2.9.9) and have also produced some newer releases (-alsa releases, not sure what is new here but it looks interesting).

I suggest we drop 2.9.10 from the tree, and the attached patch to 2.9.9 to (properly) enable 2.6.10 compatibility, and investigate the -alsa packages which linmodems have produced.

Here is the new source of slmodem packages:
http://linmodems.technion.ac.il/packages/smartlink/
Comment 1 Daniel Drake (RETIRED) gentoo-dev 2005-01-08 16:39:00 UTC
Created attachment 47982 [details, diff]
2.6.10 compatibility patch
Comment 2 Daniel Drake (RETIRED) gentoo-dev 2005-01-08 18:30:00 UTC
Sasha also tells me that there are no differences between 2.9.9 and 2.9.10 other than the licensing. linmodems will be doing a 2.9.9a release shortly which will incorporate the patch attached here.
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2005-01-12 12:51:12 UTC
I have added the 2.9.9a ebuild into portage. It just needs to be marked stable before 2005.0 is made.
Comment 4 Daniel Drake (RETIRED) gentoo-dev 2005-01-16 16:43:25 UTC
Bump..snapshot date is creeping up
Comment 5 Jos Delbar 2005-01-19 03:29:22 UTC
There is at least one difference between version 2.9.9 and version 2.9.10, concerning ALSA modem device selection.

See: http://bugs.gentoo.org/show_bug.cgi?id=60676

I'll take a look at the linmodems ALSA version and let you know if they have corrected the problem there as well.
Comment 6 Jos Delbar 2005-01-19 05:43:03 UTC
Created attachment 48937 [details, diff]
patches slmodem-2.9.9a/modem/modem_cmdline.c

linmodems did not fix the issue, so I'm attaching a new patch that applies to
their slmodem-2.9.9a.
Comment 7 Daniel Drake (RETIRED) gentoo-dev 2005-01-19 06:02:45 UTC
Where did you get this code from? we cannot take code from 2.9.10 as it has a very restrictive license
Comment 8 Jos Delbar 2005-01-19 06:15:45 UTC
This is basically the patch I wrote for version 2.9.9, reapplied to the new linmodems version. I submitted this patch to SmartLink a few months ago. I didn't get any response from them, but the issue was fixed in 2.9.10.

There shouldn't be any license issues with this patch. As you can see in BUG #60676, I created this patch independently before 2.9.10 was available.
Comment 9 Daniel Drake (RETIRED) gentoo-dev 2005-01-21 08:09:30 UTC
2.9.9a-r1 is in portage with this fix. Could you please confirm that it works ASAP. I'd like to mark this stable before the 2005.0 snapshot which is a matter of hours away...
Comment 10 Jos Delbar 2005-01-21 08:48:12 UTC
I'll have access to a phone line in a few hours.
I'll try to get back to you ASAP.
Comment 11 Jos Delbar 2005-01-21 12:09:20 UTC
I can confirm the patch does what it is supposed to do, slmodemd will no longer force to ALSA device hw:1.
Comment 12 Daniel Drake (RETIRED) gentoo-dev 2005-01-21 13:12:03 UTC
Thanks for the quick test. This is now stable :)