Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 770922 - dev-vcs/git-2.26.2 identified environment bug
Summary: dev-vcs/git-2.26.2 identified environment bug
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High major (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-16 12:18 UTC by fabrice nicol
Modified: 2021-02-17 15:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild environment file (emerge_env,141.47 KB, text/plain)
2021-02-16 12:18 UTC, fabrice nicol
Details
emerge_info (emerge_info,5.57 KB, text/plain)
2021-02-16 12:19 UTC, fabrice nicol
Details
emerge -pqv (emerge_pqv,405 bytes, text/plain)
2021-02-16 12:19 UTC, fabrice nicol
Details
build log (emerge_build_log,222.10 KB, application/octet-stream)
2021-02-16 12:20 UTC, fabrice nicol
Details

Note You need to log in before you can comment on or make changes to this bug.
Description fabrice nicol 2021-02-16 12:18:54 UTC
Created attachment 686925 [details]
ebuild environment file

Building Gentoo from scratch in a clean VM fails when portage tries to build =dev/vcs-2.26.2 (current package).

The bug was identified.
The environment file declares the Makefile variable QUIET as "false" (l. 226).
This in turn causes a bug in work/git-2.26.2/templates/Makefile, l.36, target boilerplates.made:    

    $(QUIET)umask 022 (...)

which is resolved as:

    falseumask 022

This is caused by the fact that the ebuild environment file wrongly masks and prevails over the internal Makefile conditional define:

ifdef V
  QUIET = @
endif

Proposed solution:
change the ebuild environment file at line 226:

- QUIET="false"
+ QUIET=""

Currently this looks like a major bug as git is overly ubiquitous in developers' platforms.
Comment 1 fabrice nicol 2021-02-16 12:19:30 UTC
Created attachment 686928 [details]
emerge_info
Comment 2 fabrice nicol 2021-02-16 12:19:55 UTC
Created attachment 686931 [details]
emerge -pqv
Comment 3 fabrice nicol 2021-02-16 12:20:21 UTC
Created attachment 686934 [details]
build log
Comment 4 Ionen Wolkens gentoo-dev 2021-02-16 13:45:13 UTC
This sounds strange, I see no reference to QUIET in the env file on this end, plus 2.26.2 been stable since April 2020.

fwiw I can reproduce if I "QUIET=false emerge -1 dev-vcs/git" which I see as not much different than doing CC=false, please verify that your environment is clean and/or try to see where this is coming from, e.g. grep -r QUIET /etc/portage
Comment 5 Ionen Wolkens gentoo-dev 2021-02-16 13:52:35 UTC
To clarify, the environment file is just reflecting what you have set (rather than setting it). That means it would be there if QUIET=false was exported before running emerge.
Comment 6 fabrice nicol 2021-02-16 15:48:44 UTC
Correct.
Although quite clean, the environment had a QUIET=false export before building started.
Ideally it would be preferable to protect git Makefiles against such scoping issues but this is more a job for git code maintainers than for Gentoo's.
Issue solved. 
Thanks.