Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77038 - Bacula ebuild should use make || die (continues even when errors)
Summary: Bacula ebuild should use make || die (continues even when errors)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: App-Backup Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-07 08:53 UTC by Aquila
Modified: 2005-07-02 21:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for all ebuilds (makedie.patch,6.13 KB, text/plain)
2005-01-07 08:54 UTC, Aquila
Details
Initial enchancement (bacula-1.36.0.ebuild.diff,1.23 KB, patch)
2005-01-11 04:55 UTC, INODE64 Sistemas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aquila 2005-01-07 08:53:06 UTC
I had an emerge of bacula that failed in a directory for some reason, but portage continued to run. I don't think this is expected behaviour...
The following lines should be updated imho:
make static-baula-fd
make static-console
make static-bacula-dir
make static-gnome-console
make static-wx-console
make static-bacula-sd
It's very confusing when a program doesn't work and it emerged fine. This bug applies to all bacula ebuilds so marking this bug as critical.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
i686-pc-linux-gnu-g++   -L../lib -L../cats -L../findlib -o bacula-dir dird.o 
admin.o authenticate.o autoprune.o backup.o bsr.o catreq.o dird_conf.o expand.o 
fd_cmds.o getmsg.o inc_conf.o job.o jobq.o mountreq.o msgchan.o next_vol.o 
newvol.o recycle.o restore.o run_conf.o scheduler.o sql_cmds.o ua_acl.o ua_cmds.
o ua_dotcmds.o ua_query.o ua_input.o ua_label.o ua_output.o ua_prune.o ua_purge.
o ua_restore.o ua_run.o ua_select.o ua_server.o ua_status.o ua_tree.o verify.o \
      -lsql -lbac -lfind -lm -lpthread
ua_cmds.o(.text+0x3eb3): In function `update_volpool(UAContext*, char*, 
MEDIA_DBR*)':
: undefined reference to `db_make_inchanger_unique(JCR*, s_db*, MEDIA_DBR*)'
ua_label.o(.text+0x246): In function `update_slots(UAContext*)':
: undefined reference to `db_make_inchanger_unique(JCR*, s_db*, MEDIA_DBR*)'
ua_label.o(.text+0x3d5): In function `update_slots(UAContext*)':
: undefined reference to `db_make_inchanger_unique(JCR*, s_db*, MEDIA_DBR*)'
ua_label.o(.text+0x446): In function `update_slots(UAContext*)':
: undefined reference to `db_make_inchanger_unique(JCR*, s_db*, MEDIA_DBR*)'
ua_label.o(.text+0x4bb): In function `update_slots(UAContext*)':
: undefined reference to `db_make_inchanger_unique(JCR*, s_db*, MEDIA_DBR*)'
collect2: ld returned 1 exit status
make[1]: *** [bacula-dir] Error 1
make[1]: Leaving directory `/var/tmp/portage/bacula-1.34.4/work/bacula-1.34.4/
src/dird'


   ====== Error in /var/tmp/portage/bacula-1.34.4/work/bacula-1.34.4/src/dird 
======
...
from emerge.log: 
1105111369:  >>> emerge (4 of 4) app-admin/bacula-1.34.4 to /
1105111369:  === (4 of 4) Cleaning (app-admin/bacula-1.34.4::/usr/portage/app-
admin/bacula/bacula-1.34.4.ebuild)
1105111370:  === (4 of 4) Compiling/Merging (app-admin/bacula-1.34.4::/usr/
portage/app-admin/bacula/bacula-1.34.4.ebuild)
1105111561:  === (4 of 4) Updating world file (app-admin/bacula-1.34.4)
1105111561:  === (4 of 4) Post-Build Cleaning (app-admin/bacula-1.34.4::/usr/
portage/app-admin/bacula/bacula-1.34.4.ebuild)
1105111562:  >>> AUTOCLEAN: app-admin/bacula
1105111562:  --- AUTOCLEAN: Nothing unmerged.
1105111562:  ::: completed emerge (4 of 4) app-admin/bacula-1.34.4 to /
1105111562:  *** Finished. Cleaning up...
1105111564:  *** exiting successfully.
1105111569:  *** terminating.


Expected Results:  
fail with an error

Portage 2.0.51-r3 (default-linux/x86/2004.3, gcc-3.3.4, glibc-2.3.4.20040808-r1, 
2.6.9-gentoo-r12n i686)
=================================================================
System uname: 2.6.9-gentoo-r12n i686 Intel(R) Pentium(R) 4 CPU 2.60GHz
Gentoo Base System version 1.4.16
distcc 2.16 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.90.0.1.1-r3
Headers:  sys-kernel/linux-headers-2.4.21-r1
Libtools: sys-devel/libtool-1.5.2-r7
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=pentium4 -funroll-loops -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.
3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /
usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ 
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/
share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -march=pentium4 -funroll-loops -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig candy ccache distlocks sandbox sfperms"
GENTOO_MIRRORS="http://ftp.easynet.nl/mirror/gentoo/ http://ftp.belnet.be/
mirror/rsync.gentoo.org/gentoo/ http://ftp.gentoo.skynet.be/pub/gentoo/ http://
www.mirror.ac.uk/sites/www.ibiblio.org/gentoo/ http://ftp.snt.utwente.nl/pub/os/
linux/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.be.gentoo.org/gentoo-portage"
USE="x86 X acl acpi acpi4linux activefilter alsa apache2 apm avi berkdb bitmap-
fonts crypt cups dvd encode fam foomaticdb fortran gd gdbm gif gpm gtk gtk2imlib 
ipv6 java jpeg junit kde libwww mad mikmod motif mpeg ncurses nls oggvorbis 
opengl oss pam pda pdflib perl png python qt quicktime radeon readline ruby sdl 
spell ssl svga tcpd tetex tiff truetype xml2 xmms xv zlib video_cards_radeon 
linguas_nl"
Comment 1 Aquila 2005-01-07 08:54:16 UTC
Created attachment 47862 [details]
Patch for all ebuilds

Patch for every ebuild. If you prefer new ebuilds let me know.
Comment 2 INODE64 Sistemas 2005-01-11 04:55:14 UTC
Created attachment 48189 [details, diff]
Initial enchancement

Remove redudand readline options
disable conio and use rel readline
when no select mysql, postgresql and sqlite , use client only is more natural
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-03-13 17:42:38 UTC
zul: would you like to join app-backup?
Comment 4 Fernando Serboncini (RETIRED) gentoo-dev 2005-07-02 21:07:17 UTC
This is fixed in the new 1.36.3-r1 ebuild.