Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 77000 - media-libs/libdvdcss-0.0.3.3 has sed in global scope
Summary: media-libs/libdvdcss-0.0.3.3 has sed in global scope
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jan Brinkmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-07 02:53 UTC by Jan Brinkmann (RETIRED)
Modified: 2005-01-09 04:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
libdvdcss-0.0.3.3.ebuild.diff (libdvdcss-0.0.3.3.ebuild.diff,408 bytes, patch)
2005-01-07 05:02 UTC, Jan Brinkmann (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Brinkmann (RETIRED) gentoo-dev 2005-01-07 02:53:19 UTC
MY_PV="`echo ${PV} |sed -e 's/\./\.ogle/3'`"

according to the ebuild policy sed shouldnt be used inside of the global scope:

[...]
An external application (such as grep, sed or awk) should never be called in global scope for performance reasons, and alternatives such as using built-in bash replacement should be used instead. Useful alternatives can be found in the Advanced Bash Scripting Guide.
[...]
Comment 1 Jan Brinkmann (RETIRED) gentoo-dev 2005-01-07 05:02:52 UTC
Created attachment 47835 [details, diff]
libdvdcss-0.0.3.3.ebuild.diff

this patch removes the problem
Comment 2 Jan Brinkmann (RETIRED) gentoo-dev 2005-01-09 04:49:16 UTC
fixed.