Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 76942 - Emerging compface-1.5 fails with bad patching.
Summary: Emerging compface-1.5 fails with bad patching.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 All
: High major (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-06 13:04 UTC by Ashe
Modified: 2005-01-12 02:04 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated compface-1.5-destdir.diff (compface-1.5-destdir.diff,1.75 KB, patch)
2005-01-06 23:46 UTC, imgvg
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ashe 2005-01-06 13:04:51 UTC
Emerge of compface-1.5 fails while trying to patch.

Error message is:
* Applying compface-1.5-destdir.diff ...

 * Failed Patch: compface-1.5-destdir.diff!
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/compface-1.5/temp/compface-1.5-destdir.diff-18612.out


and from that file..

***** compface-1.5-destdir.diff *****

=====================================

PATCH COMMAND:  patch -p0 -g0 < /usr/portage/media-libs/compface/files/compface-1.5-destdir.diff

=====================================
(Stripping trailing CRs from patch.)
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naur compface-1.4.orig/Makefile.in compface-1.4/Makefile.in
|--- compface-1.4.orig/Makefile.in      2000-11-22 05:38:39.000000000 -0800
|+++ compface-1.4/Makefile.in   2004-10-05 02:34:53.307138856 -0700
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
=====================================

PATCH COMMAND:  patch -p1 -g0 < /usr/portage/media-libs/compface/files/compface-1.5-destdir.diff

=====================================
(Stripping trailing CRs from patch.)
patching file Makefile.in
Hunk #1 FAILED at 71.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.in.rej
=====================================

PATCH COMMAND:  patch -p2 -g0 < /usr/portage/media-libs/compface/files/compface-1.5-destdir.diff

=====================================
missing header for unified diff at line 4 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naur compface-1.4.orig/Makefile.in compface-1.4/Makefile.in
|--- compface-1.4.orig/Makefile.in      2000-11-22 05:38:39.000000000 -0800
|+++ compface-1.4/Makefile.in   2004-10-05 02:34:53.307138856 -0700
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
=====================================

PATCH COMMAND:  patch -p3 -g0 < /usr/portage/media-libs/compface/files/compface-1.5-destdir.diff

=====================================
missing header for unified diff at line 4 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naur compface-1.4.orig/Makefile.in compface-1.4/Makefile.in
|--- compface-1.4.orig/Makefile.in      2000-11-22 05:38:39.000000000 -0800
|+++ compface-1.4/Makefile.in   2004-10-05 02:34:53.307138856 -0700
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
=====================================

PATCH COMMAND:  patch -p4 -g0 < /usr/portage/media-libs/compface/files/compface-1.5-destdir.diff
=====================================
missing header for unified diff at line 4 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naur compface-1.4.orig/Makefile.in compface-1.4/Makefile.in
|--- compface-1.4.orig/Makefile.in      2000-11-22 05:38:39.000000000 -0800
|+++ compface-1.4/Makefile.in   2004-10-05 02:34:53.307138856 -0700
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Comment 1 Ashe 2005-01-06 13:08:31 UTC
Question? is this as simple as them just renaming the patch for the updated version and not updating the internals of the patch to refelct the new version locations?
Comment 2 Heinz Hombergs 2005-01-06 21:05:12 UTC
I got the same erorr.
Comment 3 imgvg 2005-01-06 23:46:09 UTC
Created attachment 47817 [details, diff]
Updated compface-1.5-destdir.diff

OK.  The problem is that the Makefile.in is a DOS format text file (<CR><LF>
newlines).  The patch is also DOS format, but patch <em>automatically</em>
strips out <CR> on DOS format files.  This makes the patch fail (none of the
lines match!).	The fix is to remove the <CR> from, and only from, the patch
headers.  Then patch doesn't view the file as a DOS format file.  I've attached
a fixed version of the patch (I hope).	Be warned, many editors (like vim!)
will switch to entirely DOS or entirely unix line endings automagically.  If
you want to look at it, use an editor (like vim) in binary mode!
Comment 4 Ulrich Plate (RETIRED) gentoo-dev 2005-01-07 08:01:58 UTC
Your modified patch works. Thanks!
Comment 5 Jonas Fährmann 2005-01-07 11:03:35 UTC
the updated patch works for me too now :)
Comment 6 Heinz Hombergs 2005-01-07 19:06:06 UTC
Works for me too.
Good work.
Comment 7 Akinori Hattori gentoo-dev 2005-01-12 02:04:20 UTC
eradicator fixed this bug. Closing.