Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 765889 - [kde overlay] kde-frameworks/ktexteditor-9999 failing configure on upstream 5732a12a9
Summary: [kde overlay] kde-frameworks/ktexteditor-9999 failing configure on upstream 5...
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-18 10:29 UTC by Duncan
Modified: 2021-01-18 15:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
failing build log (kde-frameworks:ktexteditor-9999:20210118-131629.log,20.10 KB, text/plain)
2021-01-18 13:27 UTC, Duncan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2021-01-18 10:29:39 UTC
I originally filed this upstream, but they can't duplicate and think it's a packaging bug, so I'm filing here.  Upstream bug is https://bugs.kde.org/show_bug.cgi?id=431768 .  The below is pasted from there (but added [Upstream] by commit IDs so it's clear they're not gentoo/kde overlay commit IDs).

[Upstream] HEAD at 5a1445bd0.  (The build first failed during normal update, but I tried again after everything else finished and ultimately bisected to the below commit, so it's not a dependency-order issue.)

[Upstream] Commit 5732a12a9 "Add pre-commit hook for clang-format" fails configure with the following warning and error:

CMake Warning at /usr/share/ECM/kde-modules/KDEGitCommitHooks.cmake:63 (message):
No clang-format executable was found, skipping the formatting pre-commit
hook
Call Stack (most recent call first):
CMakeLists.txt:137 (kde_configure_git_pre_commit_hook)


CMake Error: File /usr/share/ECM/kde-modules/kde-git-commit-hooks/pre-commit.in does not exist.
CMake Error at /usr/share/ECM/kde-modules/KDEGitCommitHooks.cmake:66 (configure_file):
configure_file Problem configuring file
Call Stack (most recent call first):
CMakeLists.txt:137 (kde_configure_git_pre_commit_hook)
Comment 1 Duncan 2021-01-18 10:53:44 UTC
As I said on the upstream bug, given the recent ecm git-hooks commit this could be the first of a number of bugs.  However this gets resolved, upstream or down, should help me know where to file any more that might result from that.

[Setting URL to upstream bug.]
Comment 2 Andreas Sturmlechner gentoo-dev 2021-01-18 11:19:23 UTC
Please attach full build.log.
Comment 3 Duncan 2021-01-18 13:27:15 UTC
Created attachment 683584 [details]
failing build log

The failing build log.  All USE flags off (USE="-debug -doc -editorconfig -git -test")

See also (upstream) ecm commit 45edd1b17 and followups.
Comment 4 jospezial 2021-01-18 13:35:02 UTC
I see the same with kde-apps/kaccounts-integration-9999
- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
CMake Warning at /usr/lib64/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):
  KPackage components should be specified in reverse domain notation.
  Appstream information won't be generated for kcm_kaccounts.
Call Stack (most recent call first):
  src/kcm/CMakeLists.txt:18 (kpackage_install_package)


CMake Error: File /usr/share/ECM/kde-modules/kde-git-commit-hooks/pre-commit.in does not exist.
CMake Error at /usr/share/ECM/kde-modules/KDEGitCommitHooks.cmake:63 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  CMakeLists.txt:63 (kde_configure_git_pre_commit_hook)

ls -l /usr/share/ECM/kde-modules/kde-git-commit-hooks/
insgesamt 8
-rwx------ 1 root root 561 18. Jan 14:26 clang-format.sh
-rwx------ 1 root root  44 18. Jan 14:26 pre-commit.in

kde-frameworks/extra-cmake-modules-9999 merges these files with wrong permissions.
Comment 5 jospezial 2021-01-18 13:41:00 UTC
works after
chmod -v a+r /usr/share/ECM/kde-modules/kde-git-commit-hooks/*
Comment 6 Alexander Lohnau 2021-01-18 14:05:02 UTC
Interesting, on my Neon Unstable the permissions are:

ls -alh /usr/share/ECM/kde-modules/kde-git-commit-hooks/clang-format.sh
.rwxr-xr-x root root 561 B Mon Jan 18 01:54:00 2021   clang-format.sh


I think the permissions set in ECM need to be adjusted.
Comment 7 Duncan 2021-01-18 14:35:57 UTC
(In reply to Alexander Lohnau from comment #6)
> Interesting, on my Neon Unstable the permissions are:
> 
> ls -alh /usr/share/ECM/kde-modules/kde-git-commit-hooks/clang-format.sh
> .rwxr-xr-x root root 561 B Mon Jan 18 01:54:00 2021   clang-format.sh
> 
> 
> I think the permissions set in ECM need to be adjusted.

(As I wrote on the upstream bug...) Testing here, read is needed, not execute.  So 0644 (rw-r--r--) or 0444 (r--r--r--) should be fine.
Comment 9 Duncan 2021-01-18 15:08:08 UTC
(In reply to Alexander Lohnau from comment #8)
> Can you confirm that
> https://invent.kde.org/frameworks/extra-cmake-modules/commit/
> 7b835ca4d837f22c49f88dabc256569a80692c6d#9a2aa4db38d3115ed60da621e012c0efc017
> 2aae fixes the issue?

Confirmed fixed, marking as such.  Thanks. =:^)
Comment 10 Duncan 2021-01-18 15:10:46 UTC
Actually resolved upstream.  Marking /that/ as such.
Comment 11 Andreas Sturmlechner gentoo-dev 2021-01-18 15:12:52 UTC
As always, thanks for reporting!