Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 764305 - sci-libs/libspatialindex-1.9.3 uses -Werror for build
Summary: sci-libs/libspatialindex-1.9.3 uses -Werror for build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: 3D Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: werror
  Show dependency tree
 
Reported: 2021-01-07 13:59 UTC by Agostino Sarubbo
Modified: 2021-03-06 10:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-01-07 13:59:15 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/libspatialindex-1.9.3 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'
Comment 1 Dennis Lamm gentoo-dev 2021-03-06 06:32:26 UTC
The only spot where -Werror occurs is the bundled gtest, therefore i will add a patch to use the system provided gtest.
Comment 2 Larry the Git Cow gentoo-dev 2021-03-06 10:02:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ef95ff8de20aaa290cc8cdf5bafed989b6f4b64

commit 4ef95ff8de20aaa290cc8cdf5bafed989b6f4b64
Author:     Dennis Lamm <expeditioneer@gentoo.org>
AuthorDate: 2021-03-06 06:38:53 +0000
Commit:     Dennis Lamm <expeditioneer@gentoo.org>
CommitDate: 2021-03-06 10:02:37 +0000

    sci-libs/libspatialindex: fixed werror
    
    Using system provided gtest instead of bundled one
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=764305
    Signed-off-by: Dennis Lamm <expeditioneer@gentoo.org>
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Closes: https://github.com/gentoo/gentoo/pull/19791
    Signed-off-by: Dennis Lamm <expeditioneer@gentoo.org>

 .../libspatialindex-1.9.3-use-system-gtest.patch   | 12 +++++++
 .../libspatialindex-1.9.3-r1.ebuild                | 37 ++++++++++++++++++++++
 2 files changed, 49 insertions(+)