compile fails with compiler errors Reproducible: Always Steps to Reproduce: 1. emerge login-app Actual Results: compile log: >>> emerge (2 of 2) x11-misc/login-app-2.0.0_alpha7 to / >>> md5 src_uri ;-) Login.app-2.0.0-Alpha-7.tar.gz >>> Unpacking source... >>> Unpacking Login.app-2.0.0-Alpha-7.tar.gz to /var/tmp/portage/login-app-2.0.0_alpha7/work >>> Source unpacked. cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o main.o main.c cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o preferences.o preferences.c In file included from preferences.c:25: preferences.h:55:49: warning: C++ style comments are not allowed in ISO C90 preferences.h:55:49: warning: (this will be reported only once per input file) In file included from panel.h:25, from main.c:24: preferences.h:55:49: warning: C++ style comments are not allowed in ISO C90 preferences.h:55:49: warning: (this will be reported only once per input file) main.c: In function `main': main.c:66: warning: implicit declaration of function `strcmp' cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o resources.o resources.c cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o switchuser.o switchuser.c switchuser.c:128:33: warning: C++ style comments are not allowed in ISO C90 switchuser.c:128:33: warning: (this will be reported only once per input file) cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o panel.o panel.c In file included from resources.c:25: preferences.h:55:49: warning: C++ style comments are not allowed in ISO C90 preferences.h:55:49: warning: (this will be reported only once per input file) In file included from panel.c:33: preferences.h:55:49: warning: C++ style comments are not allowed in ISO C90 preferences.h:55:49: warning: (this will be reported only once per input file) panel.c: In function `destroyPanel': panel.c:308: warning: implicit declaration of function `RDestroyImage' cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o graphics.o graphics.c panel.c:727:10: warning: C++ style comments are not allowed in ISO C90 panel.c:727:10: warning: (this will be reported only once per input file) cc -g -Wall -pedantic -D_GNU_SOURCE `get-wraster-flags --cflags` -DSHADOW_PASSWD -c -o util.o util.c In file included from panel.h:25, from graphics.c:25: preferences.h:55:49: warning: C++ style comments are not allowed in ISO C90 preferences.h:55:49: warning: (this will be reported only once per input file) graphics.c: In function `setCombinedWindowImage': graphics.c:76: warning: implicit declaration of function `RDestroyImage' graphics.c: In function `drawText': graphics.c:89: warning: implicit declaration of function `strlen' cc -o Login main.o preferences.o resources.o switchuser.o panel.o graphics.o util.o `get-wraster- flags --ldflags` `get-wraster-flags --libs` -lXmu -lPropList -lcrypt panel.o(.text+0x7cf): In function `destroyPanel': /var/tmp/portage/login-app-2.0.0_alpha7/work/Login.app-2.0.0-Alpha-7/panel.c:308: undefined reference to `RDestroyImage' graphics.o(.text+0x1c3): In function `setCombinedWindowImage': /var/tmp/portage/login-app-2.0.0_alpha7/work/Login.app-2.0.0-Alpha-7/graphics.c:76: undefined reference to `RDestroyImage' collect2: ld returned 1 exit status
A function in the wrlib library of windowmaker has been renamed (http://cvs.windowmaker.org/co.php/wm/wrlib/NEWS). A small patch is necessary to fix login-app (http://lists.freebsd.org/pipermail/freebsd-ports-bugs/2004-October/044429.html). The problem also applies to the latest tar-archive that I found on the homepage of the author (http://largo.windowmaker.org/files/Login.app/Login.app-2.1.0-Alpha-3.tar.gz) I attached the patch and a working ebuild.
Created attachment 48925 [details, diff] Patch to fix login-app for the new windowmaker version
Created attachment 48926 [details] Modified ebuild for the windowmaker patch
*** Bug 86431 has been marked as a duplicate of this bug. ***
according to http://largo.windowmaker.org/Login.app/downloads.php, a new (stable?) version of the 2.1.x line will be released within 24 hours. i will wait for that before committing. if the problem still exists, then i will apply your patch to the new version and make it a bump at the same time
just an fyi, that page also states: "Last modified: Wednesday, July 17, 8:34:42AM PST, 2002." IIRC, that '24 hours' message has been there for a long, long time.
(In reply to comment #6) > just an fyi, that page also states: > "Last modified: Wednesday, July 17, 8:34:42AM PST, 2002." > > IIRC, that '24 hours' message has been there for a long, long time. right you are... sorry, i did a quick scan, and saw the "17" and thought it was today...
fixed in cvs... thanks
