Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 76267 - update mp32ogg to use debian version
Summary: update mp32ogg to use debian version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tony Vroon (RETIRED)
URL: http://packages.debian.org/unstable/s...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-31 16:11 UTC by Chris Arndt
Modified: 2005-01-01 07:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
quality.diff (quality.diff,2.68 KB, patch)
2005-01-01 07:44 UTC, Tony Vroon (RETIRED)
Details | Diff
mp32ogg-0.11-r4-quality.patch (mp32ogg-0.11-r4-quality.patch,2.68 KB, patch)
2005-01-01 07:55 UTC, Tony Vroon (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Arndt 2004-12-31 16:11:37 UTC
the debian version includes change to mpg321 and also adds the option to set the output quality.

Reproducible: Always
Steps to Reproduce:
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2005-01-01 04:09:49 UTC
These changes are already in portage.
[ebuild  N    ] media-sound/mp32ogg-0.11-r3

This depends on the virtual/mpg123 virtual which is normally satisfied by mpg321. I see no additional patches being applied in the .deb that the Gentoo ebuild does not have.
Comment 2 Chris Arndt 2005-01-01 07:19:20 UTC
Thanks for the comments.
If you looks, the current patch already changes from mpg123 to mpg321.
The bigger difference is that the debian release also has a patch that adds the capability of overiding the oggvobis encoding quality.

The debian version has a new option called --quality.
This is essential for very low bit rate mp3s since the script doesn't consider them and they end up being very large without the option to manually specify the ogg vorbis encoding quality.

Could you look at this again?
I believe a quick diff should show the new option.
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2005-01-01 07:44:01 UTC
Created attachment 47314 [details, diff]
quality.diff

I see what you mean now, the --quality option is indeed not implemented yet.

Needed to rediff this manually because of whitespace noise and failed hunks.
Testing now.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2005-01-01 07:55:23 UTC
Created attachment 47317 [details, diff]
mp32ogg-0.11-r4-quality.patch

Missing curly bracket.
Tests okay now. Committing to CVS as -r4.
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2005-01-01 07:59:18 UTC
In CVS. Please give the ebuild two hours to propagate before syncing your tree.

Thank you for your report.