Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 761247 - dev-util/radare2-4.5.1 contains bundled libraries
Summary: dev-util/radare2-4.5.1 contains bundled libraries
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: bundled-libs
  Show dependency tree
 
Reported: 2020-12-22 12:25 UTC by Esteve Varela Colominas
Modified: 2020-12-24 18:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Formatted patch (0001-dev-util-radare2-Unbundle-some-libraries-bug-761247.patch,2.84 KB, patch)
2020-12-24 17:06 UTC, Esteve Varela Colominas
Details | Diff
Additional patch (0002-dev-util-radare2-Replace-docdir-patch-with-sed-line.patch,1.48 KB, patch)
2020-12-24 17:09 UTC, Esteve Varela Colominas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Esteve Varela Colominas 2020-12-22 12:25:10 UTC
Specifically, it bundles:
- sys-libs/zlib (--with-syszip)
- dev-libs/libzip (--with-syszip)
- dev-libs/xxhash (--with-sysxxhash)
- sys-apps/file (--with-sysmagic)

It'd be nice if these libraries would be linked from system packages instead. It seems app-arch/lz4 is also bundled, but it doesn't seem to be compiled, and the configure script provides no option, though meson.build does.
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2020-12-23 00:04:05 UTC
That sounds reasonable. Worth checking if radare2 has any local patches that would make unbundling problematic. Do you want to prepare a 'git am'-able patch against ::gentoo tree?
Comment 2 Esteve Varela Colominas 2020-12-24 17:06:16 UTC
Created attachment 679386 [details, diff]
Formatted patch

I'm not sure if I'm doing this right as I know next to nothing about proper Gentoo policy, and idk if this change warrants a new -r revision, but I bumped it anyway.
Comment 3 Esteve Varela Colominas 2020-12-24 17:09:32 UTC
Created attachment 679389 [details, diff]
Additional patch

Also adding a patch to replace the docdir patch with a sed -i line, to allow it to still work with different package revisions as well as the live package...

I've tested it and it seems to work.