Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 76074 - x11-base/xorg-x11-6.8.1.901 installs wrong named init-script + wrong location
Summary: x11-base/xorg-x11-6.8.1.901 installs wrong named init-script + wrong location
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2004-12-29 13:26 UTC by Stefan Briesenick (RETIRED)
Modified: 2005-01-19 22:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xorg-x11-6.8.1.901-r1.ebuild.diff (xorg-x11-6.8.1.901-r1.ebuild.diff,1.07 KB, patch)
2005-01-01 05:48 UTC, Stefan Briesenick (RETIRED)
Details | Diff
xorg-x11-6.8.1.901-r1.ebuild.diff (xorg-x11-6.8.1.901-r1.ebuild.diff,1.20 KB, patch)
2005-01-01 07:52 UTC, Stefan Briesenick (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Briesenick (RETIRED) gentoo-dev 2004-12-29 13:26:52 UTC
both files are owned (epm -qf) by xorg-x11-6.8.1.901:

/etc/init.d/xprint
/etc/init.d/xprint.init

setup_xprint_init() {
        # RH-style init script, we provide a wrapper
        exeinto /usr/lib/misc
        doexe ${D}/etc/rc.d/xprint
        # Install the wrapper
        exeinto /etc/init.d
        doexe ${FILES_DIR}/xprint.init
}

strange! The 'xprint' should go into /usr/lib/misc but it is in /etc/init.d and 'xprint.init' should be installed with newexe just as 'xinit' into /etc/init.d. In /usr/lib/misc there is no 'xprint'.

It seems, that the new xorg-x11 installs the RH-init-script into ${D}/etc/init.d instead of ${D}/etc/rc.d, so the ebuild should fail, but there's no 'die'. The wrapper is installed as xprint.init (which is basically wrong I think, it should be just 'xprint').



Reproducible: Always
Steps to Reproduce:
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2004-12-30 13:41:47 UTC
I'd appreciate if you attached a patch to fix this.
Comment 2 Stefan Briesenick (RETIRED) gentoo-dev 2004-12-30 20:12:53 UTC
ups. sorry, had no time yet to investigate the problem further (compiling xorg takes hours on my slow machine). But I will do it, if you want.
Comment 3 Stefan Briesenick (RETIRED) gentoo-dev 2004-12-31 04:38:36 UTC
Ok, I was right:

./conf.d
./conf.d/xfs
./env.d
./env.d/10xorg
./init.d
./init.d/xdm
./init.d/xfs
./init.d/xprint
./init.d/xprint.init
./pam.d
./pam.d/xdm
./pam.d/xserver
./profile.d
./profile.d/xprint.csh
./profile.d/xprint.sh
./rc.d
./rc.d/rc2.d
./rc.d/rc2.d/K21xprint
./rc.d/rc2.d/S21xprint
./rc.d/rc3.d
./rc.d/rc3.d/K21xprint
./rc.d/rc3.d/S21xprint
./rc.d/rc5.d
./rc.d/rc5.d/K21xprint
./rc.d/rc5.d/S21xprint

I will provide a patch later.

But there's another interesting thing:

[/etc/profile.d/xprint.sh]

#
# /etc/profile.d/xprint.sh
#
# Copyright (c) 2002-2004 by Roland Mainz <roland.mainz@nrubsig.org>
# please send bugfixes or comments to http://xprint.mozdev.org/

#
# Obtain list of Xprint servers
#

if [ -f "/etc/init.d/xprint" ] ; then
  XPSERVERLIST="`/bin/sh /etc/init.d/xprint get_xpserverlist`"
  export XPSERVERLIST
fi

# /etc/profile.d/xprint.sh ends here.


I think, this would be better in /etc/env.d/##xprint to meet Gentoo standards.

I will create such file with following content:

XPSERVERLIST="`/bin/sh /usr/lib/misc/xprint get_xpserverlist`"

and remove the profile.d stuff at all.
Comment 4 Stefan Briesenick (RETIRED) gentoo-dev 2004-12-31 05:28:27 UTC
ok, I'm testing my patches right now (takes some time). I will attach the patch later.
Comment 5 Stefan Briesenick (RETIRED) gentoo-dev 2005-01-01 05:48:43 UTC
Created attachment 47310 [details, diff]
xorg-x11-6.8.1.901-r1.ebuild.diff

diff to xorg-x11-6.8.1.901.ebuild
Comment 6 Stefan Briesenick (RETIRED) gentoo-dev 2005-01-01 05:51:48 UTC
using /etc/env.d didn't work. :-/

So we need the scripts in /etc/profile.d
But all in all, it's working now!
Comment 7 Stefan Briesenick (RETIRED) gentoo-dev 2005-01-01 07:37:56 UTC
hmpf! not really. It is all installed correctly now, but the /etc/profile.d/xprint.(c)sh stuff isn't working properly.

doesn't work:

XPSERVERLIST="`/bin/sh /etc/init.d/xprint get_xpserverlist`"

works:

XPSERVERLIST="`/etc/init.d/xprint get_xpserverlist`"

but if we have to patch it, then we can change it to:

XPSERVERLIST="`/usr/lib/misc/xprint get_xpserverlist`"
Comment 8 Stefan Briesenick (RETIRED) gentoo-dev 2005-01-01 07:52:28 UTC
Created attachment 47316 [details, diff]
xorg-x11-6.8.1.901-r1.ebuild.diff

adding sed
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2005-01-12 22:55:56 UTC
I've got this in xorg-x11-6.8.1.901-r1.ebuild, hoping to backport it to 6.8.0-r4. Try it out if you can, KEYWORDS="-*".
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2005-01-19 22:18:03 UTC
Fixed in 6.8.1.902