Reproducable: Always. Steps to reproduce: 1. emerge xmms-spc 2. play any .spc file and leave it running for more than approx. 3:03 Actual results: The song "ends" at 3:03 (18300/100secs, taken from src). Expected results: Any of the following: 1. Plays indefinitely. 2. Obeys "length" tag in ID666 header. 3. Plays for a configurable length of time. Ideally, it should do #2 (with an option to disable), then fall back to either #1 or #3 (configurable). Notes: This really needs to be fixed upstream. The real "bug" is the fact that, without the gentoo patch for spcxmms.c, it would play indefinitely. I actually consider _both_ of these ways (always plays indefinitely, always stops at a certain time) to be "misfeatures." The ebuild and patches I'm going to attach here do 2 things: First, they break the playlength patch out of the default patchset. Second, they add a local use flag ("nolimit") to disable the playlength patch. This keeps the current default behavior, while allowing those of us who don't like it to change it. --James
Created attachment 47081 [details] ebuild described above.
Created attachment 47082 [details, diff] Playlength patch
Created attachment 47083 [details, diff] Origial Patch minus Playlength patch.
thanks for this, but I would prefer a correct fix (#2) rather than hacking hacks. Can you put pressure on upstream to take care of that?
Perhaps, but I don't know for sure. Frankly, I don't even know if xmms-spc is still being worked on upstream. I may look into making a proper fix myself, if I can figure out how to go about it. I'll keep in touch. Meanwhile, this hack seems better to me than what's in portage right now (some songs are MUCH longer than 3:03). --James
Jeremy already added this patch to the package. Closing and Thanks for your patch
