Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 754894 - >www-client/firefox-80: add vaapi use flag
Summary: >www-client/firefox-80: add vaapi use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal enhancement
Assignee: Mozilla Gentoo Team
URL: https://forums.gentoo.org/viewtopic-t...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-11-16 09:36 UTC by Janpieter Sollie
Modified: 2021-02-18 07:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_754894.txt,6.47 KB, text/plain)
2020-11-16 09:37 UTC, Janpieter Sollie
Details
proposed patch to enable vaapi flag (file_754894.txt,1.35 KB, patch)
2020-11-16 09:38 UTC, Janpieter Sollie
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Janpieter Sollie 2020-11-16 09:36:06 UTC
firefox 82 requires USE="wayland" to be built with vaapi support.
Please add a virtual vaapi flag requiring use_wayland in order to enable vaapi.


Reproducible: Always

Steps to Reproduce:
1.compile firefox
2.enable flags in about:config
3. run firefox
4. try to play 4k video in youtube using vp9 codec
Actual Results:  
no vaapi is being used

Expected Results:  
vaapi takes over
Comment 1 Janpieter Sollie 2020-11-16 09:37:17 UTC
Created attachment 671608 [details]
emerge --info
Comment 2 Janpieter Sollie 2020-11-16 09:38:29 UTC
Created attachment 671611 [details, diff]
proposed patch to enable vaapi flag
Comment 3 Perfect Gentleman 2020-11-16 09:54:12 UTC
imo
vaapi? ( media-video/ffmpeg[vaapi] )
is much better
Comment 4 Janpieter Sollie 2020-11-16 10:02:29 UTC
(In reply to Perfect Gentleman from comment #3)
> imo
> vaapi? ( media-video/ffmpeg[vaapi] )
> is much better

yes, probably, are you sure firefox uses ffmpeg libs and does not reply on libva directly?
Comment 5 Perfect Gentleman 2020-11-16 11:11:32 UTC
(In reply to Janpieter Sollie from comment #4)
> (In reply to Perfect Gentleman from comment #3)
> > imo
> > vaapi? ( media-video/ffmpeg[vaapi] )
> > is much better
> 
> yes, probably, are you sure firefox uses ffmpeg libs and does not reply on
> libva directly?

yes, I'm sure.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-16 17:20:35 UTC
We don't have virtual flags.
Comment 7 Thomas Deutschmann (RETIRED) gentoo-dev 2020-11-16 18:14:46 UTC
I am not feeling comfortable with this hack.

The whole thing is still new and upstream is only supporting VAAPI for Wayland at this point and considers X11 as legacy (https://bugzilla.mozilla.org/show_bug.cgi?id=1662496). Patches are still welcome but exposing such a hack to our users is too risky for now. Maybe with Firefox 86 when another batch of patches have landed...
Comment 8 Janpieter Sollie 2020-11-17 08:38:55 UTC
> We don't have virtual flags.
I meant here: a virtual flag is something like 'it doesn't really change anything when compiling, it just points to the user that, when a feature is required (vaapi), it must be compiled with another flag (wayland)'.
>I am not feeling comfortable with this hack.
neither am I, but is it a good idea to hide a feature when you can read everywhere 'ff 82 supports vaapi'?
> The whole thing is still new and upstream is only supporting VAAPI for Wayland
> at this point and considers X11 as legacy 
> (https://bugzilla.mozilla.org/show_bug.cgi?id=1662496). 
> Patches are still welcome but exposing such a hack to our users is too risky for > now. Maybe with Firefox 86 when another batch of patches have landed.
And if we hard-mask the flag?