Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 754027 - dev-lang/spidermonkey-78.4.0 build fails because of system wide CXXFLAGS=-std=c++14
Summary: dev-lang/spidermonkey-78.4.0 build fails because of system wide CXXFLAGS=-std...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-11 13:01 UTC by Alexey Edelev
Modified: 2021-03-29 17:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Edelev 2020-11-11 13:01:20 UTC
dev-lang/spidermonkey-78.4.0 build fails because of CXXFLAGS="${CFLAGS} -std=c++14" are installed system wide.

If I build dev-lang/spidermonkey-78.4.0 with c++14 enabled system wide, I observe issue. 

dev-lang/spidermonkey-78.4.0 add -std=gnu++17 flag, but it's overwritten by CXXFLAGS from /etc/portage/make.conf

Compilation command looks as bellow:
/usr/bin/x86_64-pc-linux-gnu-g++ -std=gnu++17 -o special-case.o -c  -I/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build/dist/system_wrappers -include /var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/config/gcc_hidden.h -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DWASM_SUPPORTS_HUGE_MEMORY -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/js/src/new-regexp -I/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build/js/src/new-regexp -I/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build/js/src -I/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/js/src -I/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build/dist/include -I/usr/include/nspr -fPIC -DMOZILLA_CLIENT -include /var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build/js/src/js-confdefs.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wno-error=deprecated-copy -Wformat -Wformat-security -Wformat-overflow=2 -Wno-noexcept-type -fno-sized-deallocation -fno-aligned-new -march=x86-64 -O2 -pipe -std=gnu++14 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -fno-omit-frame-pointer -funwind-tables -fno-strict-aliasing -Werror=format -Wno-shadow -Wno-attributes -DV8_INTL_SUPPORT  -MD -MP -MF .deps/special-case.o.pp   /var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/js/src/new-regexp/special-case.cc

Looks like dev-lang/spidermonkey-78.4.0 ebuild should exclude all -std= flags from CXXFLAGS since it forces c++17 usage.

Reproducible: Always

Steps to Reproduce:
1.emerge -1 =dev-lang/spidermonkey-78.4.0

Actual Results:  
make[3]: *** [/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/config/makefiles/rust.mk:301: force-cargo-library-build] Error 101
make[3]: Leaving directory '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build/js/src/rust'
make[2]: *** [/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/config/recurse.mk:74: js/src/rust/target] Error 2
make[2]: Leaving directory '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build'
make[1]: *** [/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/config/recurse.mk:34: compile] Error 2
make[1]: Leaving directory '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build'
make: *** [/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/config/rules.mk:392: default] Error 2
 * ERROR: dev-lang/spidermonkey-78.4.0::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=dev-lang/spidermonkey-78.4.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=dev-lang/spidermonkey-78.4.0::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/temp/environment'.
 * Working directory: '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/build'
 * S: '/var/tmp/portage/dev-lang/spidermonkey-78.4.0/work/firefox-78.4.0/js/src'


Expected Results:  
emerge succeed

Portage 3.0.8 (python 3.7.9-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-9.3.0, glibc-2.32-r2, 5.4.72-gentoo x86_64)
=================================================================
System uname: Linux-5.4.72-gentoo-x86_64-Intel-R-_Core-TM-_i9-9900_CPU_@_3.10GHz-with-gentoo-2.7
KiB Mem:    32710452 total,  10757984 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Mon, 09 Nov 2020 09:30:01 +0000
Head commit of repository gentoo: 484480e8c287176e53897b6665db202108037ed5
sh bash 5.0_p18
ld GNU ld (Gentoo 2.34 p6) 2.34.0
app-shells/bash:          5.0_p18::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          2.7.18-r4::gentoo, 3.7.9::gentoo, 3.8.5::gentoo, 3.9.0::gentoo
dev-util/cmake:           3.18.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.34-r2::gentoo
sys-devel/gcc:            9.3.0-r1::gentoo
sys-devel/gcc-config:     2.3.2::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-vcs-ignore: true
    sync-rsync-verify-jobs: 1

local-overlay
    location: /home/portage-overlay
    masters: gentoo
    priority: 0

Installed sets: @steam
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=x86-64 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=x86-64 -O2 -pipe -std=c++14"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news nostrip parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="ru"
MAKEOPTS="-j12"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp/"
USE="X a52 aac acl acpi activities alsa amd64 avahi berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit crypt cue cups dbus declarative directfb djvu dri dts dvd dvdr emboss encode exif ffmpeg flac fortran g3dvl gdbm gif git gpm gui gzip iconv icu ipv6 jpeg kde kipi kwallet lcms libglvnd libnotify libtirpc mad mdnsresponder-compat mmx mng mp3 mp4 mpeg mtp multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma pm-utils png policykit ppds pulseaudio qml qt qt5 readline sdl seccomp spell split-usr sse sse2 ssl startup-notification svg systemd tcpd theora tiff truetype udev udisks unicode upower usb v4l v4l2 vdpau vorbis wayland widgets wifi wxwidgets x264 xattr xcb xml xv xvid zip zlib" ABI_X86="64 32" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="synaptics evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2 php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python3_7 python2_7" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="intel nvidia i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2021-03-29 17:40:26 UTC
My understanding is that you are forcing custom CXXFLAGS which are incompatible with spidermonkey. 

We are not going to block you from doing that, i.e. we will not filter these flags.
Comment 2 Alexey Edelev 2021-03-29 17:54:48 UTC
I should probably agree with this statement, but then it would be great not to start the build if the spidermonkey is incompatible with the C++ 14 flags, and stop the build at least during the configuration stage. Perhaps this is more in the purview of the Mozilla developer, and it should be done as pre-compile check. I complain about this because it cost about an hour of build time before I saw an error.