Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 753985 - sys-fs/zfs: Add USE flag "bash-completion"
Summary: sys-fs/zfs: Add USE flag "bash-completion"
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Richard Yao (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-11 08:26 UTC by Terra
Modified: 2020-11-11 17:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Terra 2020-11-11 08:26:30 UTC
Please make installing the package's 'zfs' bash-completion script conditional upon the USE flag.

The default can be enabled: +bash-completion

We have our own custom written zfs bash completion script that handles relative directory to zfs dataset resolutions and is installed with our ZFS helpers custom ebuild.

Adding this USE flag will prevent us from colliding with Gentoo's sys-fs/zfs ebuild and having to do ugly things in pkg_postinst() to override it.

Thank you.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-11-11 13:26:33 UTC
We don’t add USE flags for conditional small file installations: https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301

I suggest you use INSTALL_MASK in package.env?
Comment 2 Georgy Yakovlev archtester gentoo-dev 2020-11-11 17:56:10 UTC
^^ what Sam said.

sorry, it's against QA_POLICY to control installation of small text files via useflags.

INSTALL_MASK="
/usr/share/bash-completion/completions/zfs
/usr/share/bash-completion/completions/zpool
"

in /etc/portage/make.conf or in /etc/portage/env/sys-fs/zfs

will prevent portage from installing those files.