749651 – media-gfx/graphicsmagick-9999 patching fails in configure.ac (fixed patch attached)

Bug 749651 - media-gfx/graphicsmagick-9999 patching fails in configure.ac (fixed patch attached)

Summary: media-gfx/graphicsmagick-9999 patching fails in configure.ac (fixed patch att...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2020-10-17 08:27 UTC by A Blamey
Modified:	2021-02-07 00:38 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Flags patch for graphicsmagick-9999 (graphicsmagick-9999-flags.patch,1.80 KB, text/plain) 2020-10-17 08:27 UTC, A Blamey	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description A Blamey 2020-10-17 08:27:24 UTC

Created attachment 666131 [details]
Flags patch for graphicsmagick-9999

Building graphcismagick-9999 has been failing since the commit
http://hg.code.sf.net/p/graphicsmagick/code//rev/f41b1e712fc4
on 2020-10-03 due to changes in quoting in configure.ac

>>> Preparing source in /var/tmp/portage/media-gfx/graphicsmagick-9999/work/GraphicsMagick-9999 ...
 * Applying graphicsmagick-1.3.19-flags.patch ...
patching file configure.ac
Hunk #1 succeeded at 335 with fuzz 1 (offset -11 lines).
Hunk #2 succeeded at 3690 with fuzz 2 (offset 282 lines).
Hunk #3 FAILED at 3442.
1 out of 3 hunks FAILED -- saving rejects to file configure.ac.rej
patching file magick/GraphicsMagick-config.in
patching file Magick++/bin/GraphicsMagick++-config.in                                                                                                                    [ !! ]
 * ERROR: media-gfx/graphicsmagick-9999::gentoo failed (prepare phase):
 *   patch -p1  failed with /var/tmp/portage/media-gfx/graphicsmagick-9999/files/graphicsmagick-1.3.19-flags.patch
 *

A fixed patch is attached.
It is based on the existing graphicsmagick-1.3.19-flags.patch and has trivial non-copyrightable changes by me - I just adjusted the line ranges and added [] quotes around an argument.

Comment 1 Sam James archtester

2021-02-07 00:38:29 UTC

I unknowingly fixed this in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f14e7958e3403bb6c5785ad7e69bccc466c1c7e0. Thanks for the patch, sorry I missed it!