Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 74869 - x11-base/kdrive flags cleanup
Summary: x11-base/kdrive flags cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
: 75760 (view as bug list)
Depends on:
Blocks: 74561
  Show dependency tree
 
Reported: 2004-12-18 12:04 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-07-05 20:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
kdrive-4.3.0-r5.ebuild (kdrive-4.3.0-r5.ebuild,10.36 KB, text/plain)
2004-12-18 12:05 UTC, Diego Elio Pettenò (RETIRED) 		Details
Patch over current ebuild (kdrive.diff,1.65 KB, patch)
2004-12-18 22:04 UTC, Diego Elio Pettenò (RETIRED) 		Details | Diff
Updated patch removing truetype-fonts (kdrive.patch,1.52 KB, patch)
2004-12-19 00:22 UTC, Diego Elio Pettenò (RETIRED) 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2004-12-18 12:04:37 UTC 
As pointed out from bug #74561 x11-base/kdrive ebuild is using a local freetype flag, instead of the truetype global one.
Fixing this, I cleaned up use-flags for kdrive to more suit the ones of x11-base/xorg-x11 (so truetype-fonts take place of old truetype, truetype take place of freetype, and type1-fonts take place of type1).

I also added dependency on freetype if truetype use-flag is used.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2004-12-18 12:05:11 UTC 
Created attachment 46287 [details]
kdrive-4.3.0-r5.ebuild
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2004-12-18 19:52:20 UTC 
With small changes like this, can you attach a diff instead of a full ebuild?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2004-12-18 22:04:37 UTC 
Created attachment 46325 [details, diff]
Patch over current ebuild

Here it is :)
Comment 4 Andrew Bevitt 2004-12-18 23:23:25 UTC 
Looks good to me...
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2004-12-18 23:28:56 UTC 
+		use truetype-fonts && echo "#define BuildXTrueType YES" >> config/cf/host.def \

That line is inappropriate. truetype-fonts is _only_ for building the fonts.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2004-12-18 23:50:46 UTC 
Then there's the problem to define a way to split truetype global useflag from what is achieved by truetype-fonts useflag as I used in my patch.
Using truetype useflag like before, it's misused, because it's described as freetype dependency, but there the freetype dependency was freetype useflag.
Maybe we can simply make truetype support always-in?
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2004-12-19 00:15:29 UTC 
Just do 'em both with truetype.

Now that I look at the patch again, type1-fonts is also inappropriate for the same reason.
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2004-12-19 00:22:30 UTC 
Created attachment 46326 [details, diff]
Updated patch removing truetype-fonts

Ok, done :)
I restored type1 instead of type1-fonts and removed truetype-fonts, now
truetype useflag both add truetype fonts and freetype library.
Comment 9 SpanKY gentoo-dev 2004-12-27 08:53:06 UTC 
*** Bug 75760 has been marked as a duplicate of this bug. ***
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2005-07-05 20:38:40 UTC 
Finally applying this, after being prompted by swegener's recent post on bad USE
flags on gentoo-dev.