Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 745765 - media-sound/deadbeef-1.8.4 - allow building with wavpack and other audio formats
Summary: media-sound/deadbeef-1.8.4 - allow building with wavpack and other audio formats
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Piotr Karbowski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-30 16:42 UTC by Gleb
Modified: 2020-10-02 14:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb 2020-09-30 16:42:42 UTC
According to the ebuild, some audio formats are disabled.

		"--disable-libmad"
		"--disable-gtk2"
		"--disable-adplug"
		"--disable-coreaudio"
		"--disable-dumb"
		"--disable-alac"
		"--disable-ffap"
		"--disable-gme"
		"--disable-mms"
		"--disable-mono2stereo"
		"--disable-psf"
		"--disable-rgscanner"
		"--disable-sc68"
		"--disable-shn"
		"--disable-sid"
		"--disable-sndfile"
		"--disable-soundtouch"
		"--disable-src"
		"--disable-tta"
		"--disable-vfs-zip"
		"--disable-vtx"
		"--disable-wavpack"
		"--disable-wildmidi"
		"--disable-wma"

Is it possible to add use flags for some of the options? At least wavpack and alac would be useful.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-09-30 16:49:59 UTC
slashbeast has worked quite hard on debundling everything possible so it may require a bit of time if he decides to go ahead with this, btw.
Comment 2 Piotr Karbowski (RETIRED) gentoo-dev 2020-09-30 17:10:47 UTC
It is as Sam said.

We did not had deadbeef for a long time in tree due to licensing concerns, the plugins have lots of vendorized libraries and other crust. What I decided to do was to unbundle what I can, make sure we actually know what is linked in there and to make sure that we're not bringing security issues and licensing issues aboard. This is basically the reason why you see them disabled, and even more, they're actually removed prior to build, to make sure the build system does not slurp this code anyway (plot twist, it does it on some plugins!)

This is also covered with commit[1] message.

Both alac and wavpack are covered by ffmpeg plugin. In default configuration USE=ffmpeg gets you alac support in .mp4 and .m4a. You can also go into plugin configuration and add 'wv' there to list of supported extensions.

I've already added to default supported extensions list ape there, I can add wv too.

Let me know if it solves your need or if I really should dig into those plugins.

[1] https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd8ef4388c48ac2305be8dc35fe4d665cceeb541
Comment 3 Gleb 2020-09-30 17:29:44 UTC
Thank you for your work, I do appreciate it. I am aware of the situation with deadbeef and its licensing issues, as it's absent in most distros for the same reason.

I have some music in alac and wv. wv is very popular as iso.wv single file albums. I was using the version from deadbeef overlay, so I thought that the new version from gentoo repo lacks wv support.

wavpack is an open source format so native support would be a better choice, but if it's too much work then I can live with the ffmpeg variant. I can see that there could be issues with alac as it's an Apple format. Is wv uses a different plugin / decoder? I wasn't aware that it can be used via ffmpeg or in some other way.


Also, is it still possible to build plugins (e.g. filebrowser) from the deadbeef-overlay at least?


BTW, I can't build deadbeef on my machine. It fails on applying a patch:

 * Applying deadbeef-1.8.0-fix-gettext.patch ...
patching file Makefile.am
Hunk #2 FAILED at 57.
1 out of 2 hunks FAILED -- saving rejects to file Makefile.am.rej
patching file configure.ac
Hunk #1 FAILED at 17.
Hunk #2 FAILED at 157.
Hunk #3 FAILED at 948.
3 out of 3 hunks FAILED -- saving rejects to file configure.ac.rej

Should I file a separate ticket for this?
Comment 4 Piotr Karbowski (RETIRED) gentoo-dev 2020-09-30 17:50:01 UTC
Looks like you're not building our deadbeef. There's no deadbeef-1.8.0-fix-gettext.patch in ::gentoo. We have deadbeef-1.8.4. Maybe you use /etc/portage/patches/media-sound/deadbeef? Drop it.

I am not suggesting that ALAC or WV is not useful. What I am saying is that you can enable use 'ffmpeg', then go to edit -> preferences -> plugins -> ffmpeg plugin -> configure and add there ';wv' at the end, since mp4 and m4a is already there. This will give you deadbeef that can play ALAC and WAVEPACK without us bending over backward with the dropped plugins. The question is, is it good enough for you or is there any feature that ffmpeg plugin does not cover?
Comment 5 Alexander Tsoy 2020-09-30 21:24:18 UTC
(In reply to Piotr Karbowski from comment #2)
> I've already added to default supported extensions list ape there, I can add
> wv too.
Unfortunately this doesn't work. At least not with an iso.wv format.
Comment 6 Alexander Tsoy 2020-09-30 21:33:03 UTC
There is also relatively widespread zip.wv format which requires zip plugin.

And thank you for doing this work. :)
Comment 7 Piotr Karbowski (RETIRED) gentoo-dev 2020-10-01 21:43:27 UTC
wavpack USE pushed. Let me know if both ffmpeg USE and wavpack USE allows you to use play all yours alac and wv files.
Comment 8 Piotr Karbowski (RETIRED) gentoo-dev 2020-10-02 14:09:53 UTC
feel free to reopen if alac's m4a or wavpack *.wv does not work with the latest changes pushed to tree.