745012 – app-office/libreoffice-6.4.6.2-r2 uses -Werror for build

Bug 745012 - app-office/libreoffice-6.4.6.2-r2 uses -Werror for build

Summary: app-office/libreoffice-6.4.6.2-r2 uses -Werror for build

Status:	RESOLVED NEEDINFO

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Office Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	werror
	Show dependency tree

Reported:	2020-09-28 06:56 UTC by Agostino Sarubbo
Modified:	2021-05-05 01:48 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Agostino Sarubbo gentoo-dev

2020-09-28 06:56:29 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-office/libreoffice-6.4.6.2-r2 uses -Werror for build.
Discovered on: amd64 (internal ref: tinderbox)

-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

NOTE: If you want to change the summary, to avoid auto-filed duplicates, please at least keep the word '-Werror'

Comment 1 Andreas Sturmlechner gentoo-dev

2021-05-05 01:31:39 UTC

No build.log.

Comment 2 Sam James archtester

2021-05-05 01:48:10 UTC

(In reply to Andreas Sturmlechner from comment #1)
> No build.log.

ago and I have disagreed on this before, so for clarity: it is not always obvious what triggers -Werror to appear/be used, so a build log really is useful. It’s not a “it’s used or it isn’t” thing. It could be used in a bundled library or wherever in certain conditions.

So please yes include them for these