Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 740124 - net-ftp/git-ftp-1.6.0 - uploads to FTP servers the Git way
Summary: net-ftp/git-ftp-1.6.0 - uploads to FTP servers the Git way
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL: https://github.com/git-ftp/git-ftp
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-03 01:34 UTC by Michael Lawrence
Modified: 2020-09-03 17:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Manifest (Manifest,609 bytes, text/plain)
2020-09-03 01:34 UTC, Michael Lawrence
Details
git-ftp-1.6.0.ebuild (git-ftp-1.6.0.ebuild,1.03 KB, text/plain)
2020-09-03 01:35 UTC, Michael Lawrence
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Lawrence 2020-09-03 01:34:30 UTC
Created attachment 657990 [details]
Manifest

HOMEPAGE="https://github.com/git-ftp/" 

used Dark Elf's emake toy , it least builds but sandbox then hates on me. 
emake install dies 

ebuild needs a minor amount of polish .. 



https://github.com/necrose99/gentoo-binhost python hook can die.. 50 megs oh like GHC yup that too.. 

emerge -bavgk "new-pkg"  and auto git-ftp "new-pkg" etc (packages.gz/packages) file

for a shared tinder box might prove far more reliable/useful.
Comment 1 Michael Lawrence 2020-09-03 01:35:16 UTC
Created attachment 657992 [details]
git-ftp-1.6.0.ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2020-09-03 13:13:13 UTC
Comment on attachment 657992 [details]
git-ftp-1.6.0.ebuild

># Copyright 1999-2019 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2
>#generated by emake-0.3.3
>
>EAPI=6

Why not 7?

>DESCRIPTION=""

DESCRIPTION cannot be empty. See the Summary of this bug report for what upstream suggests it should be.

>HOMEPAGE="https://github.com/git-ftp/"

No, that's not the HOMEPAGE, this is:

https://github.com/git-ftp/git-ftp

>
>SRC_URI="https://github.com/git-ftp/git-ftp/archive/${PV}.tar.gz -> git-ftp-${PV}.tgz"
>
>LICENSE=""

LICENSE cannot be empty.

>SLOT="0"
>KEYWORDS="amd64 ~x86 ~arm ~amd64 ~*"

Did you test on all those architectures?

>IUSE=""
>
>RDEPEND=""
>DEPEND="
>	${RDEPEND}
>"

No need to set empty IUSE/RDEPEND/DEPEND.

>
>S=${WORKDIR}/git-ftp-${PV}/

That's the default so don't set S.

>src_unpack() {
>	unpack "git-ftp-${PV}.tgz"
>}

The default src_unpack() handles this better.

>src_compile() {
>	if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
>		emake prefix=$EPREFIX//usr || die "emake failed"
>	fi
>}

No need to emulate emake's functionality and then call emake after all; the entire src_compile() duplicates its default implementation, so remove it.

>src_install() {
>	if [[ -f "Makefile" ]] || [[ -f "GNUmakefile" ]] || [[ -f "makefile" ]] ; then
>		emake DESTDIR="${D}" prefix=${EPREFIX}//usr install
>	fi

Same as with src_compile() but with more problems. Just call:

        default

here

>	if ! declare -p DOCS >/dev/null 2>&1 ; then
>		local d
>		for d in README* ChangeLog AUTHORS NEWS TODO CHANGES THANKS BUGS FAQ CREDITS CHANGELOG ; do
>			[[ -s "${d}" ]] && dodoc "${d}"
>		done
>	elif $(declare -p DOCS | grep -q "^declare -a ") ; then
>		dodoc "${DOCS[@]}"
>	else
>		dodoc ${DOCS}
>	fi

No idea what this is, but DOCS is not set in the ebuild so I guess you want to use whatever DOCS was set in the environment?

>}
Comment 3 Michael Lawrence 2020-09-03 17:47:53 UTC
https://github.com/git-ftp/git-ftp/blob/master/git-ftp

itself is pure bash so this should be ok then on any plaform bash runs fine on.

rpi-64 

make install /usr/local/bin 

runs ok 


if my rpi64 dies on 1,000's more compiles <root>/packages/ least will live on 


https://gitweb.gentoo.org/repo/user/darkelf.git/tree/app-portage/emake 

(sure wish it did ie more eapi7 

--prep=qmake or ninja or etc.. )

however for getting a nearly works  ebuild in 10 seconds or less i'm not griping to much.