Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 739332 - net-wireless/gnuradio-3.8.2.0 dropped boost placeholder patch.
Summary: net-wireless/gnuradio-3.8.2.0 dropped boost placeholder patch.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Radio project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-08-27 21:18 UTC by Malcolm Lashley
Modified: 2020-09-21 18:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated version of the 3.8.1 boost-placeholder patch for 3.8.2.0 (0002-boost_qualify_placeholders_with_their_full_namespace_382.patch,45.68 KB, patch)
2020-08-27 21:29 UTC, Malcolm Lashley
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Malcolm Lashley 2020-08-27 21:18:15 UTC
The 3.8.2 bump dropped the boost-placeholder patch added in [1]

Yet the upstream 3.8-branch still lacks a fix[2], so the same compilation issue with placeholder in the global namespace exists when compiling with current boost, again.

Example error (the rest of the log is the same as in the previously fixed report...)

/var/tmp/portage/net-wireless/gnuradio-3.8.2.0/work/gnuradio-3.8.2.0/gnuradio-runtime/lib/block.cc: In constructor ‘gr::block::block(const string&, gr::io_signature::sptr, gr::io_signature::sptr)’:
/var/tmp/portage/net-wireless/gnuradio-3.8.2.0/work/gnuradio-3.8.2.0/gnuradio-runtime/lib/block.cc:64:78: error: ‘_1’ was not declared in this scope
   64 |     set_msg_handler(d_system_port, boost::bind(&block::system_handler, this, _1));
      |                                                                              ^~


[1] https://github.com/gentoo/gentoo/commit/8f794520eea47dcfc145bc24c524f0295bda9ddc
[2] https://github.com/gnuradio/gnuradio/pull/3566

Reproducible: Always

Steps to Reproduce:
1.Attempt to install gnuradio-3.8.2.0 with boost-1.73.0
2.
3.
Actual Results:  
1. Failure (as per description)

Expected Results:  
We don't drop patches until we confirm upstream has actually fixed them ;-)
Comment 1 Malcolm Lashley 2020-08-27 21:29:21 UTC
Created attachment 657202 [details, diff]
Updated version of the 3.8.1 boost-placeholder patch for 3.8.2.0

Here's the fixed up patch.
Comment 2 Rick Farina (Zero_Chaos) gentoo-dev 2020-09-21 18:46:41 UTC
The patch didn't apply, and it built for me with stable boost.  My apologies for missing it.  I have re-added a variant of this patch from upstream which hopefully avoids this issue.