Due to the ongoing life of bug #11359, most people will never see the enotice to run libperl_rebuilder. Since there is an externally documented method of rebuilding stuff that was affected by a library build, namely revdep-rebuild, I propose calling libperl_rebuilder, or its successor perl-cleaner, from revdep-rebuild. Reproducible: Always Steps to Reproduce: 1. emerge world 2. perl stuff gets updated 3. nobody sees the enotice to run libperl_rebuilder Actual Results: Things were mysteriously broken. Expected Results: The script used to clean up after the libperl upgrade should have been called from revdep-rebuild. The revdep-rebuild tool is documented in the gentoolkit section (and many other places), so many (most? all?) people should be running it on a regular basis anyway. The libperl cleanup script should use the same command options as revdep-rebuild. General comments on perl-cleaner follow: - Change the options so that it follows the example set by revdep-rebuild. The default, with no options specified, should be to clean everything (currently the "all" option). - When using "ask", cat the lists of ebuild packages instead of using less. It feels somewhat disconcerting to use q(uit) inside less when you really want the operation to continue. less also removes the text from the terminal, so you can't compare the before and after. - The "Updating ph files" section currently does not go into the log file. - Redirect error messages from find to /dev/null. It looks a little scary seeing "find: /opt/blackdown-jdk-1.4.2.01/jre/lib/i386/classic/: No such file or directory" in the middle of something that is working properly. Kudos on the new script. It is much nicer than the old libperl_rebuilder. I had to give up and kill libperl_rebuilder on one machine because it just kept going on and on. Assuming perl-cleaner did everything required, it was much faster and cleaner.
I think I covered all of your suggestions in the last release of perl-cleaner except for the redirecting to dev/null - attempts to do that were sadly bad (too tired to explore that further). Let me know if you have any questions (or if this bug needs to be left open), Mike
Great to see that perl-cleaner has become part of portage. I'm surprised that "find ... 2> /dev/null" wouldn't work for you. I see in a couple of places that you pipe the output of find, but I thought that redirection and pipes could be combined. It's been a while since I wrote any serious sh scripts. I just ran "perl-cleaner all", but I can't give it a real test until the next time perl gets upgraded. I don't really want to muck up any of my systems downgrading and then upgrading perl. I still think that it should accept the same arguments as revdep-rebuild, so that you don't need to supply an "all" argument to get it to work within revdep-rebuild. The call inside revdep-rebuild could just pass the original revdep-rebuild command line directly to perl-cleaner. Has revdep-rebuild been modified to call perl-cleaner? I couldn't find it in a grep of revdep-rebuild, but I don't know if that script calls others which might then call perl-cleaner when required.
Perl team, this should probably be assigned to tools-portage. However, before I do so, I wanted to know your thoughts on this enhancement. I'm very hesitant to add this to revdep-rebuild as long as perl-cleaner is not installed to /usr/bin or /usr/sbin.
*** Bug 62306 has been marked as a duplicate of this bug. ***
app-admin/perl-cleaner is up
Created attachment 60732 [details, diff] perl-cleaner.73932.patch Minor patch for perl-cleaner: - Fixes case where the libperl action can mistakenly identify packages as linking to libperl.so - Sends stderr from find to /dev/null - Corrects a small typo
patch committed in svn
can we get perl-cleaner to accept '-p' and '--pretend' like revdep-rebuild? thanks.
I've got a long plane flight coming up -one of my goals was to redo perl-cleaner in perl (for shorter, cleaner script - and hey, if you have to use perl-cleaner, you already have perl :) - consider it on the list of things to do.
Mass re-assign.
A better description of how it works can be found here: http://www.tldp.org/LDP/abs/html/x12970.html
... disregard that, wrong tab :(
Reopen if I got this wrong, but bug #11359 is long gone, is this one even valid anymore? Please test.
Sorry, I have no Gentoo machines any more. You are on your own.
