Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734734 - media-libs/mesa-20.1.4 - why check for CONFIG_CHECKPOINT_RESTORE?
Summary: media-libs/mesa-20.1.4 - why check for CONFIG_CHECKPOINT_RESTORE?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-30 10:34 UTC by CaptainBlood
Modified: 2020-11-21 00:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (media-libs:mesa-20.1.4:20200729-213027.log.gz,80.77 KB, application/gzip)
2020-07-30 10:37 UTC, CaptainBlood
Details

Note You need to log in before you can comment on or make changes to this bug.
Description CaptainBlood 2020-07-30 10:34:52 UTC
Installed versions:  20.1.4^t(00:37:19 30/07/2020)(X classic dri3 egl gallium gbm gles2 libglvnd llvm vaapi vdpau wayland xa xvmc zstd -d3d9 -debug -gles1 -lm-sensors -opencl -osmesa -selinux -test -unwind -valgrind -vulkan -vulkan-overlay ABI_MIPS="-n32 -n64 -o32" ABI_RISCV="-lp64 -lp64d" ABI_S390="-32 -64" ABI_X86="64 -32 -x32" KERNEL="linux" VIDEO_CARDS="i965 iris -freedreno -i915 -intel -lima -nouveau -panfrost -r100 -r200 -r300 -r600 -radeon -radeonsi -vc4 -virgl -vivante -vmware")

grep CHECKPOINT_RESTORE .config 
# CONFIG_CHECKPOINT_RESTORE is not set

Maybe I misunderstood conditions or behavior...


Reproducible: Always
Comment 1 CaptainBlood 2020-07-30 10:37:08 UTC
Created attachment 651600 [details]
build log
Comment 2 Matt Turner gentoo-dev 2020-07-30 19:37:18 UTC
I expect this is the result of me messing up the logic in

commit 8b385d3cf6e678fcae6e7d3c915055a960bf6157
Author: Matt Turner <mattst88@gentoo.org>
Date:   Tue Jul 28 12:17:29 2020 -0700

    media-libs/mesa: Check for CHECKPOINT_RESTORE on i965/iris
    
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

which I fixed in

commit bce6b540deae1d2ba0b0ecec0c07b573c2d0b8bc
Author: Matt Turner <mattst88@gentoo.org>
Date:   Wed Jul 29 13:25:36 2020 -0700

    media-libs/mesa: Fix logic error
    
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

So I think it's fixed now.
Comment 3 ShadowCat8 2020-11-21 00:06:38 UTC
Greetings,

As I just saw this same behavior with media-libs/mesa-20.1.10, I want to understand what exactly is triggering this.

...<snip>...
 * Messages for package media-libs/mesa-20.1.10:

 *   CONFIG_CHECKPOINT_RESTORE:  is not set when it should be.
 * Please check to make sure these options are set correctly.
 * Failure to do so may cause unexpected problems.
...<snip>...

And, 

 ~ # emerge -pv mesa

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R    ] media-libs/mesa-20.1.10::gentoo  USE="X classic dri3 egl gallium gbm gles2 llvm zstd -d3d9 -debug -gles1 -lm-sensors -opencl -osmesa (-selinux) -test -unwind -vaapi -valgrind -vdpau -vulkan -vulkan-overlay -wayland -xa -xvmc" ABI_X86="(64) -32 (-x32)" VIDEO_CARDS="intel nouveau radeon radeonsi (-freedreno) -i915 -i965 -iris (-lima) (-panfrost) -r100 -r200 -r300 -r600 (-vc4) -virgl (-vivante) -vmware" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB
...<snip>...

So, "i965" and "iris" are both disabled, however "intel" *is* enabled, though not by my configs.

 ~ # grep -r 'VIDEO_CARDS' /etc/portage/*
 ~ # 

And my USE (from "emerge --info"):

USE="acl acpi amd64 apm audiofile avi bindist bzip2 crypt cups dvd exif ffmpeg gif hardened iconv imagemagick ipv6 jpeg libglvnd libtirpc multilib mysql mysqli ncurses nls nptl openmp pam pcre pie png quicktime readline samba seccomp sensord sockets speex split-usr ssl ssp svg tcpd theora tiff unicode usb wmf xattr xmp xpm xtpax xvid zlib"

The only entry I have for package.use/mesa:

# 20200311 - @world updates 
# required by virtual/opengl-7.0-r2::gentoo
# required by media-video/ffmpeg-4.1.3::gentoo
# required by @selected
# required by @world (argument)
>=media-libs/mesa-19.3.5 X

So, is the "intel" VIDEO_CARD entry also triggering the check for CONFIG_CHECKPOINT_RESTORE too?  I see that entry is coming from /usr/portage/profiles/arch/amd64/make.defaults:

...<snip>...
# Donnie Berkholz <dberkholz@gentoo.org> (2006-08-18)
# Defaults for video drivers
VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa"
...<snip>...

I want to make sure I understand this so I can decide if I can safely ignore it since this is on a headless server.