Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 734640 - media-libs/libjpeg-turbo should use BDEPEND with EAPI=7
Summary: media-libs/libjpeg-turbo should use BDEPEND with EAPI=7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-07-30 01:48 UTC by David Michael
Modified: 2020-08-20 21:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-07-30 01:48:10 UTC
None of the EAPI 7 ebuilds defines BDEPEND, so they have nasm in DEPEND.  When cross-compiling to amd64 or x86, that makes it cross-compile the assembler while cmake is looking for /usr/bin/nasm.  It needs to be moved to BDEPEND to work.

Reproducible: Always

Steps to Reproduce:
1. emerge -v media-libs/libjpeg-turbo  # with a sysroot profile

Actual Results:  
It cross-compiles the nasm dependency.

Expected Results:  
It should install nasm natively.

This patch fixes nasm.  Maybe the Java dependency should also be in BDEPEND?  (I don't know; Java has been dead to me for years.)

--- media-libs/libjpeg-turbo/libjpeg-turbo-2.0.4-r1.ebuild
+++ media-libs/libjpeg-turbo/libjpeg-turbo-2.0.4-r1.ebuild
@@ -22,7 +22,8 @@
 	!media-libs/jpeg:62"
 RDEPEND="${COMMON_DEPEND}
 	java? ( >=virtual/jre-1.5 )"
-DEPEND="${COMMON_DEPEND}
+DEPEND="${RDEPEND}"
+BDEPEND="
 	amd64? ( ${ASM_DEPEND} )
 	x86? ( ${ASM_DEPEND} )
 	amd64-fbsd? ( ${ASM_DEPEND} )
@@ -31,7 +32,7 @@
 	x86-linux? ( ${ASM_DEPEND} )
 	x64-macos? ( ${ASM_DEPEND} )
 	x64-cygwin? ( ${ASM_DEPEND} )
-	java? ( >=virtual/jdk-1.5 )"
+"
 
 MULTILIB_WRAPPED_HEADERS=( /usr/include/jconfig.h )
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-07-30 12:49:07 UTC
Your patch seems to suggest that virtual/jre and virtual/jdk are the same.
Comment 2 David Michael 2020-07-30 12:53:08 UTC
Sorry, I misread them as the same package name.

--- media-libs/libjpeg-turbo/libjpeg-turbo-2.0.4-r1.ebuild
+++ media-libs/libjpeg-turbo/libjpeg-turbo-2.0.4-r1.ebuild
@@ -23,6 +23,8 @@
 RDEPEND="${COMMON_DEPEND}
 	java? ( >=virtual/jre-1.5 )"
 DEPEND="${COMMON_DEPEND}
+	java? ( >=virtual/jdk-1.5 )"
+BDEPEND="
 	amd64? ( ${ASM_DEPEND} )
 	x86? ( ${ASM_DEPEND} )
 	amd64-fbsd? ( ${ASM_DEPEND} )
@@ -31,7 +33,7 @@
 	x86-linux? ( ${ASM_DEPEND} )
 	x64-macos? ( ${ASM_DEPEND} )
 	x64-cygwin? ( ${ASM_DEPEND} )
-	java? ( >=virtual/jdk-1.5 )"
+"
 
 MULTILIB_WRAPPED_HEADERS=( /usr/include/jconfig.h )
Comment 3 David Michael 2020-08-20 21:00:46 UTC
Looks like this was fixed in https://github.com/gentoo/gentoo/commit/a58b0c2f479b8fc33436db2287ffb15db1cf04a7 .