With the newer ocaml >= 4.06, this ebuild will also DEPEND on dev-ml/num which apparently is no longer packaged with ocaml. I'm not sure what the best way to do the ebuild for this one... since it has 4 version numbers ... can we call it "3.1.7-r2" or is that against gentoo policy? I manually hacked the last ebuild: SRC_URI="https://github.com/ygrek/mldonkey/releases/download/release-3-1-7-2/mldonkey-3.1.7-2.tar.bz2" S=${WORKDIR}/mldonkey-3.1.7-2 (I also had to change the call to emake to "emake -j1" in order to avoid a compilation error, about some unbound thing with CommonOptions) Changelog ========= 3.1.7-2 - 2020/07/05 -------------------- Patch release to fix build, no code changes (version in binary unchanged) * fix links to website throughout * fix build when num library is missing (#47) 3.1.7 - 2020/06/21 ------------------ * improvements to build process * fix build with OCaml up to 4.09.0 * BT: drop isoHunt link NB When building with OCaml >= 4.06 and Bittorrent network enabled - ocaml num library has to be present
Created attachment 652222 [details] A modified ebuild file works on my system I modified mldonkey-3.1.6-r1.ebuild and made it working for version 3.1.7-2.
We have 3.1.7 but not _p2.
Wdym? Why hasn't "3.1.7-2" been merged in yet?
(In reply to Dennis Nezic from comment #3) > Wdym? Why hasn't "3.1.7-2" been merged in yet? I was just updating the bug to the new maintainer and noting that we have 3.1.7 but not -2. Not sure why not yet.
I haven't added 3.1.7-2 because it doesn't seem to have any relevant changes from 3.1.7 as stated by the upstream maintainer himself: > Patch release to fix build, no code changes (version in binary unchanged) The nums.py issue was tracked under Gentoo bug 704684 and upstream issue #27[1] and should be already fixed, please update this ticket if you are still having issues building net-p2p/mldonkey with an updated Portage tree. [1] https://github.com/ygrek/mldonkey/issues/27
Actually, net-p2p/mldonkey-3.1.7 already uses the 3.1.7-2 tarball: # emerge -pf =net-p2p/mldonkey-3.1.7 These are the packages that would be fetched, in order: Calculating dependencies... done! http://distfiles.gentoo.org/distfiles/ab/mldonkey-3.1.7-2.tar.bz2 https://github.com/ygrek/mldonkey/releases/download/release-3-1-7-2/mldonkey-3.1.7-2.tar.bz2 As said, version 3.1.7-2 upstream is the same code as 3.1.7 and there was no version bump: https://github.com/ygrek/mldonkey/blob/release-3-1-7-2/config/configure.in#L23
Looks like someone already updated the ebuild. I guess changing the SRC_URI was the simplest most elegant solution. I shall close this bug?
Edit: Hmmm, portage's changelog says it was always like this. My bad for not noticing!
